From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@kernel.org>
Cc: peterz@infradead.org, Ingo Molnar <mingo@kernel.org>,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com,
eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com,
sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
tumanova@linux.vnet.ibm.com, kan.liang@intel.com,
penberg@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] Add support for remote unwind
Date: Fri, 6 May 2016 08:58:15 -0300 [thread overview]
Message-ID: <20160506115815.GW11069@kernel.org> (raw)
In-Reply-To: <1462525154-125656-1-git-send-email-hekuang@huawei.com>
Em Fri, May 06, 2016 at 08:59:06AM +0000, He Kuang escreveu:
> Currently, perf script uses host unwind methods to parse perf.data
> callchain info regardless of the target architecture. So we get wrong
> result and no promotion when do remote unwind on other
> platforms/machines.
Thanks for working on this, being able to record on one machine and do
analysis in another, of a different hw architectures is indeed a goal
for the perf tools!
Jiri, if you could please take a look, that would be really great!
- Arnaldo
> This patch set adds build tests for the supported platforms for remote
> unwinding, and checks the map elf info for each thread, use remote
> unwind methods instead.
>
> Only x86 and aarch64 is added in this patch set to show the work flow,
> other platforms can be added easily.
>
> We can see the right result for unwind infos on different machines,
> for example: we record perf.data on i686 qemu with '-g' option and
> parse it on x86_64 machine.
>
> before this patchset:
>
> hello 1071 [000] 417.567832: probe:sys_close: (c1169d60)
> c1169d61 sys_close ([kernel.kallsyms])
> c189c0d7 sysenter_past_esp ([kernel.kallsyms])
> b77c8ba9 [unknown] ([vdso32])
>
> after:
>
> hello 1071 [000] 417.567832: probe:sys_close: (c1169d60)
> c1169d61 sys_close ([kernel.kallsyms])
> c189c0d7 sysenter_past_esp ([kernel.kallsyms])
> b77c8ba9 [unknown] ([vdso32])
> b76e51cc close (/lib/libc-2.22.so)
> 804842e fib (/tmp/hello)
> 804849d main (/tmp/hello)
> b762546e __libc_start_main (/lib/libc-2.22.so)
> 8048341 _start (/tmp/hello)
>
> Thanks, discussion welcomed.
>
> He Kuang (8):
> perf tools: Omit DWARF judgement when recording dwarf callchain
> perf script: Add options for custom vdso name
> perf build: Add build-test for libunwind cross-platforms support
> perf build: Add build-test for debug-frame on arm/arm64
> perf tools: Promote proper messages for cross-platform unwind
> perf callchain: Add support for cross-platform unwind
> perf callchain: Support x86 target platform
> perf callchain: Support aarch64 cross-platform
>
> tools/build/Makefile.feature | 11 +++-
> tools/build/feature/Makefile | 26 +++++++-
> tools/build/feature/test-libunwind-aarch64.c | 26 ++++++++
> tools/build/feature/test-libunwind-arm.c | 27 +++++++++
> .../feature/test-libunwind-debug-frame-aarch64.c | 16 +++++
> .../build/feature/test-libunwind-debug-frame-arm.c | 16 +++++
> tools/build/feature/test-libunwind-debug-frame.c | 16 -----
> tools/build/feature/test-libunwind-x86.c | 27 +++++++++
> tools/build/feature/test-libunwind-x86_64.c | 27 +++++++++
> .../arch/arm64/include/libunwind/libunwind-arch.h | 18 ++++++
> tools/perf/arch/arm64/util/unwind-libunwind.c | 5 +-
> .../arch/x86/include/libunwind/libunwind-arch.h | 18 ++++++
> tools/perf/arch/x86/util/unwind-libunwind.c | 42 +++++++++++++
> tools/perf/builtin-script.c | 2 +
> tools/perf/config/Makefile | 35 ++++++++++-
> tools/perf/util/Build | 13 +++-
> tools/perf/util/dso.c | 7 +++
> tools/perf/util/dso.h | 1 +
> tools/perf/util/symbol-elf.c | 16 +++++
> tools/perf/util/symbol.c | 50 ++++++++++++++++
> tools/perf/util/symbol.h | 3 +
> tools/perf/util/thread.c | 70 ++++++++++++++++++++--
> tools/perf/util/thread.h | 14 ++++-
> tools/perf/util/unwind-libunwind.c | 50 +++++++++++++---
> tools/perf/util/unwind-libunwind_common.c | 60 +++++++++++++++++++
> tools/perf/util/unwind.h | 30 ++++++++++
> tools/perf/util/util.c | 2 -
> 27 files changed, 589 insertions(+), 39 deletions(-)
> create mode 100644 tools/build/feature/test-libunwind-aarch64.c
> create mode 100644 tools/build/feature/test-libunwind-arm.c
> create mode 100644 tools/build/feature/test-libunwind-debug-frame-aarch64.c
> create mode 100644 tools/build/feature/test-libunwind-debug-frame-arm.c
> delete mode 100644 tools/build/feature/test-libunwind-debug-frame.c
> create mode 100644 tools/build/feature/test-libunwind-x86.c
> create mode 100644 tools/build/feature/test-libunwind-x86_64.c
> create mode 100644 tools/perf/arch/arm64/include/libunwind/libunwind-arch.h
> create mode 100644 tools/perf/arch/x86/include/libunwind/libunwind-arch.h
> create mode 100644 tools/perf/util/unwind-libunwind_common.c
>
> --
> 1.8.5.2
prev parent reply other threads:[~2016-05-06 11:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 8:59 [PATCH 0/8] Add support for remote unwind He Kuang
2016-05-06 8:59 ` [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain He Kuang
2016-05-06 11:47 ` Arnaldo Carvalho de Melo
2016-05-07 18:03 ` Jiri Olsa
2016-05-09 16:16 ` Arnaldo Carvalho de Melo
2016-05-10 1:44 ` Hekuang
2016-05-10 20:30 ` [tip:perf/core] perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support tip-bot for He Kuang
2016-05-06 8:59 ` [PATCH 2/8] perf script: Add options for custom vdso name He Kuang
2016-05-06 11:49 ` Arnaldo Carvalho de Melo
2016-05-07 18:14 ` Jiri Olsa
2016-05-06 8:59 ` [PATCH 3/8] perf build: Add build-test for libunwind cross-platforms support He Kuang
2016-05-07 18:20 ` Jiri Olsa
2016-05-06 8:59 ` [PATCH 4/8] perf build: Add build-test for debug-frame on arm/arm64 He Kuang
2016-05-07 18:24 ` Jiri Olsa
2016-05-06 8:59 ` [PATCH 5/8] perf tools: Promote proper messages for cross-platform unwind He Kuang
2016-05-07 18:41 ` Jiri Olsa
2016-05-07 18:42 ` Jiri Olsa
2016-05-06 8:59 ` [PATCH 6/8] perf callchain: Add support " He Kuang
2016-05-06 11:56 ` Arnaldo Carvalho de Melo
2016-05-06 8:59 ` [PATCH 7/8] perf callchain: Support x86 target platform He Kuang
2016-05-06 8:59 ` [PATCH 8/8] perf callchain: Support aarch64 cross-platform He Kuang
2016-05-06 11:58 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506115815.GW11069@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tumanova@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).