From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758451AbcEFMRJ (ORCPT ); Fri, 6 May 2016 08:17:09 -0400 Received: from mail.kernel.org ([198.145.29.136]:41908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbcEFMRH (ORCPT ); Fri, 6 May 2016 08:17:07 -0400 Date: Fri, 6 May 2016 09:17:01 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Chris Phlipot , adrian.hunter@intel.com, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] perf tools: fix incorrect ordering of callchain entries Message-ID: <20160506121701.GX11069@kernel.org> References: <1461831551-12213-1-git-send-email-cphlipot0@gmail.com> <1461831551-12213-2-git-send-email-cphlipot0@gmail.com> <20160428084903.GC24122@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160428084903.GC24122@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Apr 28, 2016 at 10:49:03AM +0200, Jiri Olsa escreveu: > On Thu, Apr 28, 2016 at 01:19:06AM -0700, Chris Phlipot wrote: > > The existing implementation of thread__resolve_callchain, under certain > > circumstances, can assemble callchain entries in the incorrect order. > > SNIP > > > 0x558f2a04c774 > > 0x558f2a04dded > > rand > > __random > > ret_from_intr > > do_IRQ > > handle_irq > > handle_edge_irq > > handle_irq_event > > handle_irq_event_percpu > > gen8_irq_handler > > > > Signed-off-by: Chris Phlipot > > for this patch > > Acked-by: Jiri Olsa Tested, nice catch and fix, applied. A good thing would be to be able to reverse the callchain order dynamicly, in the TUI, shouldn't be hard, right? - Arnaldo > can't really ack the rest of the patchset, but it looks good to me > > thanks, > jirka