From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758287AbcEFOPl (ORCPT ); Fri, 6 May 2016 10:15:41 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:37824 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757956AbcEFOPj (ORCPT ); Fri, 6 May 2016 10:15:39 -0400 Date: Fri, 6 May 2016 16:15:32 +0200 From: Thierry Reding To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , treding@nvidia.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector Message-ID: <20160506141532.GC4641@ulmo.ba.sec> References: <1462454674-2246-1-git-send-email-noralf@tronnes.org> <1462454674-2246-5-git-send-email-noralf@tronnes.org> <20160506140347.GB4641@ulmo.ba.sec> <20160506140816.GD27098@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UPT3ojh+0CqEDtpF" Content-Disposition: inline In-Reply-To: <20160506140816.GD27098@phenom.ffwll.local> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --UPT3ojh+0CqEDtpF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 06, 2016 at 04:08:16PM +0200, Daniel Vetter wrote: > On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote: > > On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Tr=C3=B8nnes wrote: > > > Add function to create a simple connector for a panel. > >=20 > > I'm not sure I see the usefulness of this. Typically you'd attach a > > panel to an encoder/connector, in which case you already have the > > connector. > >=20 > > Perhaps it would become more obvious why we need this if you posted > > patches that show where this is used? >=20 > The other helpers give you a simple drm pipeline with plane, crtc & > encoder all baked into on drm_simple_pipeline structure. The only thing > variable you have to hook up to that is the drm_connector. And I think for > dead-simple panels avoiding the basic boilerplate in that does indeed make > some sense. Avoiding boilerplate is good, but I have a difficult time envisioning how you might want to use this. At the same time I'm asking myself how we know that this helper is any good if we haven't seen it used anywhere and actually see the boilerplate go away. Thierry --UPT3ojh+0CqEDtpF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXLKcBAAoJEN0jrNd/PrOhx0EQAJZEhnG+66eooUrnjHmvrPZq sdIWaejeWEVbZ6mFzix2QmN2fVRClVfeOxfqoG966gvLzLTxunt+Yfg1NqxtW41p PsxSRu6HhSGjDImm6VrVOLIlsA7R05F6le51NK40G8ECSxMZFmYd60Kl/ASzBeEV I6WTJXf2OxVrX8dxJtx/xfk5SnURoYg+hcw6qs6Rr1GkAo6A44hNRf0Hyctn4d4T exgO2zq2q7RK402B/lQa3gIZIpoRVP9fxiaXYINDiX51SXQTfcyMUibboSc5o8aj uJP3RePUGdKhsnpLgci+ICtpt3TSLyXJEf92pzCdYzTAh0L10ngCGVezAXByAqI4 z7PpFXzbZ9i6eUnYgW5Q0/BSLVOpU6GyWs4AZneflGKrmIbRobAzAspVb54Vh8CU M61gop2NAP481ho1saW9mGaaQQNf6cnp4lyiagFsVpn4kBl0QcKZhXbMZO/oMPRb L+0qvufNYlYbaIyCguH9oNAeS4G5xrcoKB73yL+1sFiKsU4f55/NGPf8mxLKQ9Jh x5KpHhkn9NuYRlk0Y5mqgNp+R3v2GCu4o3lYASaLwk7aTYoXOxyCuWf8h685f93p OrWzloYizHgyWTJxH7h9QvbkkH80/Cf2Cq1HHokq2zmnlLwc2MtsEwFY8fY/t0AQ 8KnEZSeRQailNiPTqbsc =X39v -----END PGP SIGNATURE----- --UPT3ojh+0CqEDtpF--