From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758486AbcEFSss (ORCPT ); Fri, 6 May 2016 14:48:48 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33480 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755867AbcEFSsq (ORCPT ); Fri, 6 May 2016 14:48:46 -0400 Date: Fri, 6 May 2016 11:48:42 -0700 From: Bjorn Andersson To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, maxime.coquelin@st.com, ohad@wizery.com, linux-remoteproc@vger.kernel.org, Ludovic Barre Subject: Re: [PATCH 2/5] remoteproc: core: Add rproc OF look-up functions Message-ID: <20160506184842.GE1256@tuxbot> References: <1462454983-13168-1-git-send-email-lee.jones@linaro.org> <1462454983-13168-3-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462454983-13168-3-git-send-email-lee.jones@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 05 May 06:29 PDT 2016, Lee Jones wrote: > - of_rproc_byindex(): look-up and obtain a reference to a rproc > using the DT phandle "rprocs" and a index. > > - of_rproc_byname(): lookup and obtain a reference to a rproc > using the DT phandle "rprocs" and "rproc-names". > > Signed-off-by: Ludovic Barre > Signed-off-by: Lee Jones > --- I like the idea of having these helpers, but we already have rproc_get_by_phandle() so these helpers should be built upon that rather than adding the additional list. Regards, Bjorn