From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759063AbcEFW2B (ORCPT ); Fri, 6 May 2016 18:28:01 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58740 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758495AbcEFW2A (ORCPT ); Fri, 6 May 2016 18:28:00 -0400 Date: Sat, 7 May 2016 00:27:58 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 12/21] net: dsa: mv88e6xxx: factorize switch reset Message-ID: <20160506222758.GC2073@lunn.ch> References: <1462571843-14397-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1462571843-14397-13-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462571843-14397-13-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c > index dbbda4e..b744ed5 100644 > --- a/drivers/net/dsa/mv88e6xxx.c > +++ b/drivers/net/dsa/mv88e6xxx.c > @@ -2551,6 +2551,68 @@ restore_page_0: > return ret; > } > > +static int _mv88e6xxx_switch_reset(struct mv88e6xxx_priv_state *ps) > +{ You missed removing the _ prefix. Thanks for removing the others. With so much less noise, it is easier to review the patches. Andrew