From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759140AbcEFW33 (ORCPT ); Fri, 6 May 2016 18:29:29 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58746 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756722AbcEFW32 (ORCPT ); Fri, 6 May 2016 18:29:28 -0400 Date: Sat, 7 May 2016 00:29:26 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 13/21] net: dsa: mv88e6xxx: factorize global setup Message-ID: <20160506222926.GD2073@lunn.ch> References: <1462571843-14397-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1462571843-14397-14-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462571843-14397-14-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > -int mv88e6xxx_setup_common(struct mv88e6xxx_priv_state *ps) > +static int _mv88e6xxx_setup_global(struct mv88e6xxx_priv_state *ps) Another _ prefix. Andrew