From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223AbcEGTQc (ORCPT ); Sat, 7 May 2016 15:16:32 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35560 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbcEGTQ2 (ORCPT ); Sat, 7 May 2016 15:16:28 -0400 Date: Sat, 07 May 2016 15:16:16 -0400 (EDT) Message-Id: <20160507.151616.1691068510125905278.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: manish.chopra@qlogic.com, sony.chacko@qlogic.com, rajesh.borundia@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch 2/2] netxen: reversed condition in netxen_nic_set_link_parameters() From: David Miller In-Reply-To: <20160505131944.GC3038@mwanda> References: <20160505131944.GC3038@mwanda> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 May 2016 12:16:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter Date: Thu, 5 May 2016 16:19:44 +0300 > My static checker complains that we are using "autoneg" without > initializing it. The problem is the ->phy_read() condition is reversed > so we only set this on error instead of success. > > Signed-off-by: Dan Carpenter Applied.