From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750969AbcEGSO4 (ORCPT ); Sat, 7 May 2016 14:14:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57336 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbcEGSOz (ORCPT ); Sat, 7 May 2016 14:14:55 -0400 Date: Sat, 7 May 2016 20:14:45 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] perf script: Add options for custom vdso name Message-ID: <20160507181445.GC19977@krava> References: <1462525154-125656-1-git-send-email-hekuang@huawei.com> <1462525154-125656-3-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462525154-125656-3-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2016 at 08:59:08AM +0000, He Kuang wrote: > When unwinding callchain on different machine, vdso info should be > provided so the unwind process won't be interrupted if address fell > into vdso region. > > Signed-off-by: He Kuang > --- > tools/perf/builtin-script.c | 2 ++ > tools/perf/util/dso.c | 7 +++++++ > tools/perf/util/dso.h | 1 + > tools/perf/util/symbol.c | 1 + > tools/perf/util/symbol.h | 1 + > 5 files changed, 12 insertions(+) > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index 8f6ab2a..c88b547 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -2001,6 +2001,8 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused) > "file", "vmlinux pathname"), > OPT_STRING(0, "kallsyms", &symbol_conf.kallsyms_name, > "file", "kallsyms pathname"), > + OPT_STRING(0, "vdso", &symbol_conf.vdso_name, > + "file", "vdso pathname"), > OPT_BOOLEAN('G', "hide-call-graph", &no_callchain, > "When printing symbols do not display call chain"), > OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory", > diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c > index 8e639543..344db10 100644 > --- a/tools/perf/util/dso.c > +++ b/tools/perf/util/dso.c > @@ -21,6 +21,7 @@ char dso__symtab_origin(const struct dso *dso) > [DSO_BINARY_TYPE__OPENEMBEDDED_DEBUGINFO] = 'o', > [DSO_BINARY_TYPE__BUILDID_DEBUGINFO] = 'b', > [DSO_BINARY_TYPE__SYSTEM_PATH_DSO] = 'd', > + [DSO_BINARY_TYPE__SYSTEM_PATH_DSO_CUSTOM] = 'r', > [DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE] = 'K', > [DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE_COMP] = 'm', > [DSO_BINARY_TYPE__GUEST_KALLSYMS] = 'g', > @@ -113,6 +114,11 @@ int dso__read_binary_type_filename(const struct dso *dso, > build_id_hex, build_id_hex + 2); > break; > > + case DSO_BINARY_TYPE__SYSTEM_PATH_DSO_CUSTOM: > + { > + snprintf(filename, size, "%s", symbol_conf.vdso_name); > + break; > + } > case DSO_BINARY_TYPE__VMLINUX: > case DSO_BINARY_TYPE__GUEST_VMLINUX: > case DSO_BINARY_TYPE__SYSTEM_PATH_DSO: > @@ -487,6 +493,7 @@ static void try_to_open_dso(struct dso *dso, struct machine *machine) > enum dso_binary_type binary_type_data[] = { > DSO_BINARY_TYPE__BUILD_ID_CACHE, > DSO_BINARY_TYPE__SYSTEM_PATH_DSO, > + DSO_BINARY_TYPE__SYSTEM_PATH_DSO_CUSTOM, could you please elaborate on how this one gets set? don't we already store it under .debug? also it seems fairly vdso specific, we shouldn't call it DSO_CUSTOM thanks, jirka