linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
	jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com,
	namhyung@kernel.org, adrian.hunter@intel.com,
	sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com,
	tumanova@linux.vnet.ibm.com, kan.liang@intel.com,
	penberg@kernel.org, dsahern@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] perf build: Add build-test for libunwind cross-platforms support
Date: Sat, 7 May 2016 20:20:24 +0200	[thread overview]
Message-ID: <20160507182024.GD19977@krava> (raw)
In-Reply-To: <1462525154-125656-4-git-send-email-hekuang@huawei.com>

On Fri, May 06, 2016 at 08:59:09AM +0000, He Kuang wrote:
> Currently only test for local libunwind. We should check all supported
> platforms so we can use them to parse perf.data with callchain info on
> different machines.
> 
> Signed-off-by: He Kuang <hekuang@huawei.com>
> ---
>  tools/build/Makefile.feature                 |  8 ++++++++
>  tools/build/feature/Makefile                 | 16 ++++++++++++++++
>  tools/build/feature/test-libunwind-aarch64.c | 26 ++++++++++++++++++++++++++
>  tools/build/feature/test-libunwind-arm.c     | 27 +++++++++++++++++++++++++++
>  tools/build/feature/test-libunwind-x86.c     | 27 +++++++++++++++++++++++++++
>  tools/build/feature/test-libunwind-x86_64.c  | 27 +++++++++++++++++++++++++++
>  6 files changed, 131 insertions(+)
>  create mode 100644 tools/build/feature/test-libunwind-aarch64.c
>  create mode 100644 tools/build/feature/test-libunwind-arm.c
>  create mode 100644 tools/build/feature/test-libunwind-x86.c
>  create mode 100644 tools/build/feature/test-libunwind-x86_64.c
> 
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index 9f87861..139e99c 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -49,6 +49,10 @@ FEATURE_TESTS_BASIC :=			\
>  	libslang			\
>  	libcrypto			\
>  	libunwind			\
> +	libunwind-x86			\
> +	libunwind-x86_64		\
> +	libunwind-arm			\
> +	libunwind-aarch64		\
>  	pthread-attr-setaffinity-np	\
>  	stackprotector-all		\
>  	timerfd				\
> @@ -92,6 +96,10 @@ FEATURE_DISPLAY ?=			\
>  	libslang			\
>  	libcrypto			\
>  	libunwind			\
> +	libunwind-x86			\
> +	libunwind-x86_64		\
> +	libunwind-arm			\
> +	libunwind-aarch64		\

I dont think we should display status of libs needed only for cross builds
it'll be OFF for most of the people and create unnecessary tension ;-)

thanks,
jirka

  reply	other threads:[~2016-05-07 18:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06  8:59 [PATCH 0/8] Add support for remote unwind He Kuang
2016-05-06  8:59 ` [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain He Kuang
2016-05-06 11:47   ` Arnaldo Carvalho de Melo
2016-05-07 18:03   ` Jiri Olsa
2016-05-09 16:16     ` Arnaldo Carvalho de Melo
2016-05-10  1:44       ` Hekuang
2016-05-10 20:30   ` [tip:perf/core] perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support tip-bot for He Kuang
2016-05-06  8:59 ` [PATCH 2/8] perf script: Add options for custom vdso name He Kuang
2016-05-06 11:49   ` Arnaldo Carvalho de Melo
2016-05-07 18:14   ` Jiri Olsa
2016-05-06  8:59 ` [PATCH 3/8] perf build: Add build-test for libunwind cross-platforms support He Kuang
2016-05-07 18:20   ` Jiri Olsa [this message]
2016-05-06  8:59 ` [PATCH 4/8] perf build: Add build-test for debug-frame on arm/arm64 He Kuang
2016-05-07 18:24   ` Jiri Olsa
2016-05-06  8:59 ` [PATCH 5/8] perf tools: Promote proper messages for cross-platform unwind He Kuang
2016-05-07 18:41   ` Jiri Olsa
2016-05-07 18:42   ` Jiri Olsa
2016-05-06  8:59 ` [PATCH 6/8] perf callchain: Add support " He Kuang
2016-05-06 11:56   ` Arnaldo Carvalho de Melo
2016-05-06  8:59 ` [PATCH 7/8] perf callchain: Support x86 target platform He Kuang
2016-05-06  8:59 ` [PATCH 8/8] perf callchain: Support aarch64 cross-platform He Kuang
2016-05-06 11:58 ` [PATCH 0/8] Add support for remote unwind Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160507182024.GD19977@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=hekuang@huawei.com \
    --cc=jpoimboe@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=tumanova@linux.vnet.ibm.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).