From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751022AbcEGSUd (ORCPT ); Sat, 7 May 2016 14:20:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51078 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750935AbcEGSUc (ORCPT ); Sat, 7 May 2016 14:20:32 -0400 Date: Sat, 7 May 2016 20:20:24 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] perf build: Add build-test for libunwind cross-platforms support Message-ID: <20160507182024.GD19977@krava> References: <1462525154-125656-1-git-send-email-hekuang@huawei.com> <1462525154-125656-4-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462525154-125656-4-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 07 May 2016 18:20:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2016 at 08:59:09AM +0000, He Kuang wrote: > Currently only test for local libunwind. We should check all supported > platforms so we can use them to parse perf.data with callchain info on > different machines. > > Signed-off-by: He Kuang > --- > tools/build/Makefile.feature | 8 ++++++++ > tools/build/feature/Makefile | 16 ++++++++++++++++ > tools/build/feature/test-libunwind-aarch64.c | 26 ++++++++++++++++++++++++++ > tools/build/feature/test-libunwind-arm.c | 27 +++++++++++++++++++++++++++ > tools/build/feature/test-libunwind-x86.c | 27 +++++++++++++++++++++++++++ > tools/build/feature/test-libunwind-x86_64.c | 27 +++++++++++++++++++++++++++ > 6 files changed, 131 insertions(+) > create mode 100644 tools/build/feature/test-libunwind-aarch64.c > create mode 100644 tools/build/feature/test-libunwind-arm.c > create mode 100644 tools/build/feature/test-libunwind-x86.c > create mode 100644 tools/build/feature/test-libunwind-x86_64.c > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > index 9f87861..139e99c 100644 > --- a/tools/build/Makefile.feature > +++ b/tools/build/Makefile.feature > @@ -49,6 +49,10 @@ FEATURE_TESTS_BASIC := \ > libslang \ > libcrypto \ > libunwind \ > + libunwind-x86 \ > + libunwind-x86_64 \ > + libunwind-arm \ > + libunwind-aarch64 \ > pthread-attr-setaffinity-np \ > stackprotector-all \ > timerfd \ > @@ -92,6 +96,10 @@ FEATURE_DISPLAY ?= \ > libslang \ > libcrypto \ > libunwind \ > + libunwind-x86 \ > + libunwind-x86_64 \ > + libunwind-arm \ > + libunwind-aarch64 \ I dont think we should display status of libs needed only for cross builds it'll be OFF for most of the people and create unnecessary tension ;-) thanks, jirka