From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750966AbcEGSYZ (ORCPT ); Sat, 7 May 2016 14:24:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57492 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbcEGSYY (ORCPT ); Sat, 7 May 2016 14:24:24 -0400 Date: Sat, 7 May 2016 20:24:15 +0200 From: Jiri Olsa To: He Kuang Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] perf build: Add build-test for debug-frame on arm/arm64 Message-ID: <20160507182415.GE19977@krava> References: <1462525154-125656-1-git-send-email-hekuang@huawei.com> <1462525154-125656-5-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462525154-125656-5-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2016 at 08:59:10AM +0000, He Kuang wrote: > Debug-frame for remote platforms is not related to the host platform, > so we should test each platform separately. SNIP > diff --git a/tools/build/feature/test-libunwind-debug-frame.c b/tools/build/feature/test-libunwind-debug-frame.c > deleted file mode 100644 > index 0ef8087..0000000 > --- a/tools/build/feature/test-libunwind-debug-frame.c > +++ /dev/null > @@ -1,16 +0,0 @@ > -#include > -#include > - > -extern int > -UNW_OBJ(dwarf_find_debug_frame) (int found, unw_dyn_info_t *di_debug, > - unw_word_t ip, unw_word_t segbase, > - const char *obj_name, unw_word_t start, > - unw_word_t end); > - > -#define dwarf_find_debug_frame UNW_OBJ(dwarf_find_debug_frame) hum but we still use this in standard libdw unwind from find_proc_info in util/unwind-libunwind.c should we keep the generic version as well? thanks, jirka