From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751300AbcEHCqc (ORCPT ); Sat, 7 May 2016 22:46:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37550 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbcEHCqb (ORCPT ); Sat, 7 May 2016 22:46:31 -0400 Date: Sun, 8 May 2016 04:46:27 +0200 From: Greg KH To: Thimo Braker Cc: devel@driverdev.osuosl.org, arve@android.com, linux-kernel@vger.kernel.org, riandrews@android.com, sumit.semwal@linaro.org Subject: Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef Message-ID: <20160508024627.GA13955@kroah.com> References: <1462652523-25037-1-git-send-email-thibmorozier@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462652523-25037-1-git-send-email-thibmorozier@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 07, 2016 at 03:22:03PM -0500, Thimo Braker wrote: > Fixes a checkpatch.pl warning about 'do not add new typedefs' > > Signed-off-by: Thimo Braker > --- > drivers/staging/android/uapi/ion.h | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h > index 0a8e40f..77a46f0 100644 > --- a/drivers/staging/android/uapi/ion.h > +++ b/drivers/staging/android/uapi/ion.h > @@ -20,8 +20,6 @@ > #include > #include > > -typedef int ion_user_handle_t; > - You just broke userspace :( Sorry, you can't do this, be careful when touching files that cross the user/kernel boundry (hint, they have uapi in the path), you have to know exactly what you are doing when you do that. thanks, greg k-h