From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbcEILte (ORCPT ); Mon, 9 May 2016 07:49:34 -0400 Received: from 8bytes.org ([81.169.241.247]:53795 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbcEILtd (ORCPT ); Mon, 9 May 2016 07:49:33 -0400 Date: Mon, 9 May 2016 13:49:27 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Cc: pbonzini@redhat.com, rkrcmar@redhat.com, bp@alien8.de, gleb@kernel.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com Subject: Re: [PART2 RFC v1 1/9] iommu/amd: Detect and enable guest vAPIC support Message-ID: <20160509114927.GC13971@8bytes.org> References: <1460119770-2896-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1460119770-2896-2-git-send-email-Suravee.Suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460119770-2896-2-git-send-email-Suravee.Suthikulpanit@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 08, 2016 at 07:49:22AM -0500, Suthikulpanit, Suravee wrote: > From: Suravee Suthikulpanit > > This patch introduces a new IOMMU driver parameter, amd_iommu_guest_ir, > which can be used to specify different interrupt remapping mode for > passthrough devices to VM guest: > * legacy: Legacy interrupt remapping mode (w/ 32-bit IRTE) > * ga : Guest vAPIC interrupt remapping mode (w/ 128-bit IRTE) > > Note that the GA mode also supports legacy interrupt remapping > for non-passthrough devices with the 128-bit IRTE. Does this need to be under user control? The code can just check what the hardware supports and use the 128bit IRTEs if supported, no? Joerg