From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbcEIMIK (ORCPT ); Mon, 9 May 2016 08:08:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37031 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbcEIMII (ORCPT ); Mon, 9 May 2016 08:08:08 -0400 Date: Mon, 9 May 2016 14:08:05 +0200 From: Greg KH To: Thimo Braker Cc: labbott@redhat.com, sumit.semwal@linaro.org, arve@android.com, iandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] Staging: android: uapi: ion: Fixes indentation Message-ID: <20160509120805.GA4311@kroah.com> References: <1462707707-51783-1-git-send-email-thibmorozier@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462707707-51783-1-git-send-email-thibmorozier@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 08, 2016 at 01:41:47PM +0200, Thimo Braker wrote: > Fixes the indentation before variable names. > > Signed-off-by: Thimo Braker > --- > drivers/staging/android/uapi/ion.h | 20 ++++++++++---------- > drivers/staging/android/uapi/ion_test.h | 10 +++++----- > 2 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h > index 0a8e40f..6dda8d5 100644 > --- a/drivers/staging/android/uapi/ion.h > +++ b/drivers/staging/android/uapi/ion.h > @@ -91,11 +91,11 @@ enum ion_heap_type { > * Provided by userspace as an argument to the ioctl > */ > struct ion_allocation_data { > - size_t len; > - size_t align; > - unsigned int heap_id_mask; > - unsigned int flags; > - ion_user_handle_t handle; > + size_t len; > + size_t align; > + unsigned int heap_id_mask; > + unsigned int flags; > + ion_user_handle_t handle; Hm, that's not really a "fix" anywhere. There's no kernel rule that you have to align the fields in a structure. What "tool" told you this was necessary? So this patch isn't needed, sorry. thanks, greg k-h