public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bruno Carvalho <brunocarvalhofarias@gmail.com>
Cc: ciorneiioana@gmail.com, amitoj1606@gmail.com,
	s.demeszko@wireless-instruments.com, shraddha.6596@gmail.com,
	bhumirks@gmail.com, shivanib134@gmail.com,
	mahfouz.saif.elyazal@gmail.com, tj@kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver
Date: Mon, 9 May 2016 14:24:52 +0200	[thread overview]
Message-ID: <20160509122452.GA28034@kroah.com> (raw)
In-Reply-To: <1462678154-17462-1-git-send-email-brunocarvalhofarias@gmail.com>

On Sat, May 07, 2016 at 11:29:14PM -0400, Bruno Carvalho wrote:
> - alloc_tty_driver() is deprecated. So it is replaced by tty_alloc_driver()
> 
> Signed-off-by: Bruno Carvalho <brunocarvalhofarias@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_tty.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..c0888f5 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -306,7 +306,9 @@ int register_lte_tty_driver(void)
>  	int ret;
>  
>  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> -		tty_driver = alloc_tty_driver(GDM_TTY_MINOR);
> +		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> +					      TTY_DRIVER_REAL_RAW |
> +					      TTY_DRIVER_DYNAMIC_DEV);

You just changed the logic here, previously we were passing in 0 for the
flags, now you are setting some to a different value, why?

thanks,

greg k-h

      reply	other threads:[~2016-05-09 12:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-08  3:29 [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver Bruno Carvalho
2016-05-09 12:24 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160509122452.GA28034@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amitoj1606@gmail.com \
    --cc=bhumirks@gmail.com \
    --cc=brunocarvalhofarias@gmail.com \
    --cc=ciorneiioana@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahfouz.saif.elyazal@gmail.com \
    --cc=s.demeszko@wireless-instruments.com \
    --cc=shivanib134@gmail.com \
    --cc=shraddha.6596@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox