* [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver
@ 2016-05-08 3:29 Bruno Carvalho
2016-05-09 12:24 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Bruno Carvalho @ 2016-05-08 3:29 UTC (permalink / raw)
To: gregkh
Cc: ciorneiioana, amitoj1606, s.demeszko, shraddha.6596, bhumirks,
shivanib134, mahfouz.saif.elyazal, tj, devel, linux-kernel,
Bruno Carvalho
- alloc_tty_driver() is deprecated. So it is replaced by tty_alloc_driver()
Signed-off-by: Bruno Carvalho <brunocarvalhofarias@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index eb7e252..c0888f5 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -306,7 +306,9 @@ int register_lte_tty_driver(void)
int ret;
for (i = 0; i < TTY_MAX_COUNT; i++) {
- tty_driver = alloc_tty_driver(GDM_TTY_MINOR);
+ tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
+ TTY_DRIVER_REAL_RAW |
+ TTY_DRIVER_DYNAMIC_DEV);
if (!tty_driver)
return -ENOMEM;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver
2016-05-08 3:29 [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver Bruno Carvalho
@ 2016-05-09 12:24 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-05-09 12:24 UTC (permalink / raw)
To: Bruno Carvalho
Cc: ciorneiioana, amitoj1606, s.demeszko, shraddha.6596, bhumirks,
shivanib134, mahfouz.saif.elyazal, tj, devel, linux-kernel
On Sat, May 07, 2016 at 11:29:14PM -0400, Bruno Carvalho wrote:
> - alloc_tty_driver() is deprecated. So it is replaced by tty_alloc_driver()
>
> Signed-off-by: Bruno Carvalho <brunocarvalhofarias@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..c0888f5 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -306,7 +306,9 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = alloc_tty_driver(GDM_TTY_MINOR);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> + TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
You just changed the logic here, previously we were passing in 0 for the
flags, now you are setting some to a different value, why?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-09 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-08 3:29 [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver Bruno Carvalho
2016-05-09 12:24 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox