From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753098AbcEIMY6 (ORCPT ); Mon, 9 May 2016 08:24:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38582 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbcEIMY4 (ORCPT ); Mon, 9 May 2016 08:24:56 -0400 Date: Mon, 9 May 2016 14:24:52 +0200 From: Greg KH To: Bruno Carvalho Cc: ciorneiioana@gmail.com, amitoj1606@gmail.com, s.demeszko@wireless-instruments.com, shraddha.6596@gmail.com, bhumirks@gmail.com, shivanib134@gmail.com, mahfouz.saif.elyazal@gmail.com, tj@kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver Message-ID: <20160509122452.GA28034@kroah.com> References: <1462678154-17462-1-git-send-email-brunocarvalhofarias@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462678154-17462-1-git-send-email-brunocarvalhofarias@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 07, 2016 at 11:29:14PM -0400, Bruno Carvalho wrote: > - alloc_tty_driver() is deprecated. So it is replaced by tty_alloc_driver() > > Signed-off-by: Bruno Carvalho > --- > drivers/staging/gdm724x/gdm_tty.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c > index eb7e252..c0888f5 100644 > --- a/drivers/staging/gdm724x/gdm_tty.c > +++ b/drivers/staging/gdm724x/gdm_tty.c > @@ -306,7 +306,9 @@ int register_lte_tty_driver(void) > int ret; > > for (i = 0; i < TTY_MAX_COUNT; i++) { > - tty_driver = alloc_tty_driver(GDM_TTY_MINOR); > + tty_driver = tty_alloc_driver(GDM_TTY_MINOR, > + TTY_DRIVER_REAL_RAW | > + TTY_DRIVER_DYNAMIC_DEV); You just changed the logic here, previously we were passing in 0 for the flags, now you are setting some to a different value, why? thanks, greg k-h