From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency
Date: Mon, 9 May 2016 15:40:06 +0100 [thread overview]
Message-ID: <20160509144006.GA19473@dell> (raw)
In-Reply-To: <1461779381-3933094-1-git-send-email-arnd@arndb.de>
On Wed, 27 Apr 2016, Arnd Bergmann wrote:
> The MFD_VEXPRESS_SYSREG driver selects CLKSRC_MMIO, which in turn
> conflicts with ARCH_USES_GETTIMEOFFSET, causing a harmless Kconfig
> warning when it is set:
>
> warning: (ARCH_MVEBU && ARCH_DIGICOLOR && ARCH_GEMINI && ARCH_KEYSTONE && ARCH_MOXART && ARCH_MXS && PLAT_SPEAR && ARCH_SUNXI && ARCH_TEGRA && ARCH_U300 && PLAT_ORION && ARCH_CLPS711X && ARCH_EP93XX && ARCH_NETX && ARCH_IXP4XX && ARCH_KS8695 && ARCH_W90X900 && ARCH_PXA && ARCH_SA1100 && ARCH_OMAP1 && ARCH_BCM_IPROC && ARCH_INTEGRATOR_AP && ARCH_OMAP2PLUS && MFD_VEXPRESS_SYSREG) selects CLKSRC_MMIO which has unmet direct dependencies (!ARCH_USES_GETTIMEOFFSET)
>
> This was apparently hidden by the fact that no ARM platform that
> still sets ARCH_USES_GETTIMEOFFSET has gpiolib support, and we
> already have a dependency on GPIOLIB that I added a while ago.
>
> However, after 296ad4acb8ef ("gpio: remove deps on
> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB"), any platform can enable
> CONFIG_GPIOLIB, and that lets us enable MFD_VEXPRESS_SYSREG
> as well.
>
> This adds an explicit dependency on !ARCH_USES_GETTIMEOFFSET
> to guarantee that we can enable the CLKSRC_MMIO driver without
> getting warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 4b6d60f65429..461c0c4ff8d8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1569,7 +1569,7 @@ endmenu
>
> config MFD_VEXPRESS_SYSREG
> bool "Versatile Express System Registers"
> - depends on VEXPRESS_CONFIG && GPIOLIB
> + depends on VEXPRESS_CONFIG && GPIOLIB && !ARCH_USES_GETTIMEOFFSET
> default y
> select CLKSRC_MMIO
> select GPIO_GENERIC_PLATFORM
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-05-09 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 17:49 [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency Arnd Bergmann
2016-04-30 11:47 ` Linus Walleij
2016-05-09 14:40 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509144006.GA19473@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox