From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Borislav Petkov <bp@suse.de>, Brooks Moses <bmoses@google.com>,
linux-kernel@vger.kernel.org, Ian Kasprzak <iankaz@google.com>
Subject: Re: Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where?
Date: Mon, 9 May 2016 17:25:02 +0200 [thread overview]
Message-ID: <20160509152502.GB12472@potion> (raw)
In-Reply-To: <5730A98F.3080405@redhat.com>
2016-05-09 17:15+0200, Paolo Bonzini:
> On 09/05/2016 16:47, Radim Krčmář wrote:
>> 2016-05-09 16:00+0200, Paolo Bonzini:
>>> On 05/05/2016 10:24, Borislav Petkov wrote:
>>>> On Wed, May 04, 2016 at 05:49:27PM -0700, Brooks Moses wrote:
>>>>> When I run "make ARCH=x86 headers_install", and then write a simple C
>>>>> file that #includes "asm/kvm.h" from the resulting tree, I get a
>>>>> compiler error: the BIT() macro used on line 219 of that file is
>>>>> undefined:
>>>>
>>>> The below patch should help...
>>>>
>>>> @Paulo: btw, any chance we can fix that "signifcant" typo :-) in
>>>> KVM_CPUID_FLAG_SIGNIFCANT_INDEX or is it user-visible and cast in
>>>> stone?
>>>
>>> Unfortuntely it is cast in stone. The patch below is good though.
>>
>> We can "fix" it by introducing a second name for the entry. Do you
>> think it's worth?
>
> I don't think so, but perhaps there are precedents for doing that?
I can't think of any, and it seems pointless to me ...
next prev parent reply other threads:[~2016-05-09 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 0:49 Is BIT() in arch/x86/include/uapi/asm/kvm.h defined? Where? Brooks Moses
2016-05-05 8:24 ` Borislav Petkov
2016-05-05 19:15 ` Brooks Moses
2016-05-09 14:00 ` Paolo Bonzini
2016-05-09 14:47 ` Radim Krčmář
2016-05-09 15:15 ` Paolo Bonzini
2016-05-09 15:25 ` Radim Krčmář [this message]
2016-05-09 15:46 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509152502.GB12472@potion \
--to=rkrcmar@redhat.com \
--cc=bmoses@google.com \
--cc=bp@suse.de \
--cc=iankaz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox