From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753432AbcEIWj2 (ORCPT ); Mon, 9 May 2016 18:39:28 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34983 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbcEIWj0 (ORCPT ); Mon, 9 May 2016 18:39:26 -0400 Date: Mon, 9 May 2016 15:39:24 -0700 From: Stephen Boyd To: Maxime Ripard Cc: Mike Turquette , David Airlie , Chen-Yu Tsai , Rob Herring , Daniel Vetter , Hans de Goede , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, Boris Brezillon , Thomas Petazzoni , Alexander Kaplan , Laurent Pinchart Subject: Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Message-ID: <20160509223924.GX3492@codeaurora.org> References: <1461590572-4027-1-git-send-email-maxime.ripard@free-electrons.com> <1461590572-4027-2-git-send-email-maxime.ripard@free-electrons.com> <20160506223002.GE3492@codeaurora.org> <20160508200308.GF6167@lukather> <20160509223238.GW3492@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160509223238.GW3492@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09, Stephen Boyd wrote: > > Ok I applied this one to clk-next. > And I squashed this in to silence the following checker warning. drivers/clk/sunxi/clk-sun4i-display.c:110:33: warning: Variable length array is used. ---8<--- diff --git a/drivers/clk/sunxi/clk-sun4i-display.c b/drivers/clk/sunxi/clk-sun4i-display.c index f02e250e64ed..f8ff6c4a5633 100644 --- a/drivers/clk/sunxi/clk-sun4i-display.c +++ b/drivers/clk/sunxi/clk-sun4i-display.c @@ -107,7 +107,7 @@ static int sun4i_a10_display_reset_xlate(struct reset_controller_dev *rcdev, static void __init sun4i_a10_display_init(struct device_node *node, const struct sun4i_a10_display_clk_data *data) { - const char *parents[data->parents]; + const char *parents[4]; const char *clk_name = node->name; struct reset_data *reset_data; struct clk_divider *div = NULL; @@ -126,8 +126,8 @@ static void __init sun4i_a10_display_init(struct device_node *node, return; } - ret = of_clk_parent_fill(node, parents, data->parents); - if (ret != data->parents) { + ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents)); + if (ret != ARRAY_SIZE(parents)) { pr_err("%s: Could not retrieve the parents\n", clk_name); goto unmap; } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project