From: Baoquan He <bhe@redhat.com>
To: Corey Minyard <cminyard@mvista.com>
Cc: Corey Minyard <minyard@acm.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Vivek Goyal <vgoyal@redhat.com>, Haren Myneni <hbabu@us.ibm.com>,
dyoung@redhat.com
Subject: Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels
Date: Tue, 10 May 2016 09:37:28 +0800 [thread overview]
Message-ID: <20160510013728.GA2629@x1.redhat.com> (raw)
In-Reply-To: <5730AF76.3000608@mvista.com>
On 05/09/16 at 10:40am, Corey Minyard wrote:
> >>>>> define bttnobp
> >>>>> set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >>>>>- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >>>>>+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> >>>This is a quite nice fix.
> >>>
> >>>>> set $init_t=&init_task
> >>>>> set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> >>>>> while ($next_t != $init_t)
> >>>>> set $next_t=(struct task_struct *)$next_t
> >>>>> printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> >>>>> printf "===================\n"
> >>>>>- set var $stackp = $next_t.thread.esp
> >>>>>+ set var $stackp = $next_t.thread.sp
> >>>>> set var $stack_top = ($stackp & ~4095) + 4096
> >Missed one place here. Currently the kernel stack is decided by
> >THREAD_SIZE since the definition:
> >
> >union thread_union {
> > struct thread_info thread_info;
> > unsigned long stack[THREAD_SIZE/sizeof(long)];
> >};
> >
> >Should we get the top and bottom of stack according to this now?
> >
> >Correct me if I was wrong.
>
> I think you are correct. We should use something like:
>
> set var $stack_top = ($stackp & ~(sizeof(thread_union) - 1)) +
> sizeof(thread_union)
>
> Is this what you are suggesting?
Exactly, it's cool. Thanks!
next prev parent reply other threads:[~2016-05-10 1:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 13:51 [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels minyard
2016-04-27 12:21 ` Corey Minyard
2016-05-05 2:37 ` Baoquan He
2016-05-09 5:18 ` Baoquan He
2016-05-09 12:10 ` Corey Minyard
2016-05-09 14:29 ` Baoquan He
2016-05-09 15:40 ` Corey Minyard
2016-05-10 1:37 ` Baoquan He [this message]
2016-05-10 1:48 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510013728.GA2629@x1.redhat.com \
--to=bhe@redhat.com \
--cc=cminyard@mvista.com \
--cc=dyoung@redhat.com \
--cc=hbabu@us.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox