From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Subject: [PATCH perf/core v3 8/8] perf tools: Remove xrealloc and ALLOC_GROW
Date: Tue, 10 May 2016 14:48:01 +0900 [thread overview]
Message-ID: <20160510054801.6158.6204.stgit@devbox> (raw)
In-Reply-To: <20160510054649.6158.75771.stgit@devbox>
Remove unused xrealloc() and ALLOC_GROW() from libperf.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
tools/perf/util/Build | 1 -
tools/perf/util/cache.h | 19 -------------------
tools/perf/util/util.h | 6 ------
tools/perf/util/wrapper.c | 29 -----------------------------
4 files changed, 55 deletions(-)
delete mode 100644 tools/perf/util/wrapper.c
diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index 027bb2b..8c6c8a0 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -27,7 +27,6 @@ libperf-y += strlist.o
libperf-y += strfilter.o
libperf-y += top.o
libperf-y += usage.o
-libperf-y += wrapper.o
libperf-y += dso.o
libperf-y += symbol.o
libperf-y += symbol_fprintf.o
diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
index 1f5a93c..0d814bb 100644
--- a/tools/perf/util/cache.h
+++ b/tools/perf/util/cache.h
@@ -40,25 +40,6 @@ int split_cmdline(char *cmdline, const char ***argv);
#define alloc_nr(x) (((x)+16)*3/2)
-/*
- * Realloc the buffer pointed at by variable 'x' so that it can hold
- * at least 'nr' entries; the number of entries currently allocated
- * is 'alloc', using the standard growing factor alloc_nr() macro.
- *
- * DO NOT USE any expression with side-effect for 'x' or 'alloc'.
- */
-#define ALLOC_GROW(x, nr, alloc) \
- do { \
- if ((nr) > alloc) { \
- if (alloc_nr(alloc) < (nr)) \
- alloc = (nr); \
- else \
- alloc = alloc_nr(alloc); \
- x = xrealloc((x), alloc * sizeof(*(x))); \
- } \
- } while(0)
-
-
static inline int is_absolute_path(const char *path)
{
return path[0] == '/';
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index 88f607a..7651633 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -160,12 +160,6 @@ static inline char *gitstrchrnul(const char *s, int c)
}
#endif
-/*
- * Wrappers:
- */
-void *xrealloc(void *ptr, size_t size) __attribute__((weak));
-
-
static inline void *zalloc(size_t size)
{
return calloc(1, size);
diff --git a/tools/perf/util/wrapper.c b/tools/perf/util/wrapper.c
deleted file mode 100644
index 5f1a07c..0000000
--- a/tools/perf/util/wrapper.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * Various trivial helper wrappers around standard functions
- */
-#include "cache.h"
-
-/*
- * There's no pack memory to release - but stay close to the Git
- * version so wrap this away:
- */
-static inline void release_pack_memory(size_t size __maybe_unused,
- int flag __maybe_unused)
-{
-}
-
-void *xrealloc(void *ptr, size_t size)
-{
- void *ret = realloc(ptr, size);
- if (!ret && !size)
- ret = realloc(ptr, 1);
- if (!ret) {
- release_pack_memory(size, -1);
- ret = realloc(ptr, size);
- if (!ret && !size)
- ret = realloc(ptr, 1);
- if (!ret)
- die("Out of memory, realloc failed");
- }
- return ret;
-}
next prev parent reply other threads:[~2016-05-10 5:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 5:46 [PATCH perf/core v3 0/8] perf tools: Update strbuf to remove xrealloc Masami Hiramatsu
2016-05-10 5:46 ` [PATCH perf/core v3 1/8] perf: Rewrite strbuf not to die Masami Hiramatsu
2016-05-10 20:33 ` [tip:perf/core] perf tools: Rewrite strbuf not to die() tip-bot for Masami Hiramatsu
2016-05-10 5:47 ` [PATCH perf/core v3 2/8] perf probe: Check the return value of strbuf APIs Masami Hiramatsu
2016-05-10 20:34 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2016-05-10 5:47 ` [PATCH perf/core v3 3/8] perf help: Make check_emacsclient_version to check " Masami Hiramatsu
2016-05-10 14:56 ` Arnaldo Carvalho de Melo
2016-05-10 20:34 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2016-05-10 5:47 ` [PATCH perf/core v3 4/8] perf: Make alias handler to check return value of strbuf Masami Hiramatsu
2016-05-10 20:34 ` [tip:perf/core] perf tools: " tip-bot for Masami Hiramatsu
2016-05-10 5:47 ` [PATCH perf/core v3 5/8] perf header: Make topology checkers " Masami Hiramatsu
2016-05-10 20:35 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2016-05-10 5:47 ` [PATCH perf/core v3 6/8] perf pmu: Make pmu_formats_string " Masami Hiramatsu
2016-05-10 20:35 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2016-05-10 5:47 ` [PATCH perf/core v3 7/8] perf help: Do not use ALLOC_GROW in add_cmd_list Masami Hiramatsu
2016-05-10 20:36 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2016-05-10 5:48 ` Masami Hiramatsu [this message]
2016-05-10 20:36 ` [tip:perf/core] perf tools: Remove xrealloc and ALLOC_GROW tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510054801.6158.6204.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox