From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbcEJH2m (ORCPT ); Tue, 10 May 2016 03:28:42 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32801 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbcEJH2k (ORCPT ); Tue, 10 May 2016 03:28:40 -0400 Date: Tue, 10 May 2016 09:28:37 +0200 From: Michal Hocko To: Greg Thelen Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment Message-ID: <20160510072837.GC23576@dhcp22.suse.cz> References: <1462569810-54496-1-git-send-email-gthelen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462569810-54496-1-git-send-email-gthelen@google.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 06-05-16 14:23:30, Greg Thelen wrote: > commit f61c42a7d911 ("memcg: remove tasks/children test from > mem_cgroup_force_empty()") removed memory reparenting from the function. > > Fix the function's comment. > > Signed-off-by: Greg Thelen Acked-by: Michal Hocko > --- > mm/memcontrol.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index fe787f5c41bd..19fd76168a05 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2636,8 +2636,7 @@ static inline bool memcg_has_children(struct mem_cgroup *memcg) > } > > /* > - * Reclaims as many pages from the given memcg as possible and moves > - * the rest to the parent. > + * Reclaims as many pages from the given memcg as possible. > * > * Caller is responsible for holding css reference for memcg. > */ > -- > 2.8.0.rc3.226.g39d4020 -- Michal Hocko SUSE Labs