From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751227AbcEJIJq (ORCPT ); Tue, 10 May 2016 04:09:46 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:35028 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbcEJIJo (ORCPT ); Tue, 10 May 2016 04:09:44 -0400 Date: Tue, 10 May 2016 10:09:40 +0200 From: Ralf Baechle To: Paul Burton Cc: linux-mips@linux-mips.org, "Maciej W. Rozycki" , linux-kernel@vger.kernel.org, James Hogan , Markos Chandras Subject: Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation Message-ID: <20160510080940.GD16402@linux-mips.org> References: <1461243895-30371-1-git-send-email-paul.burton@imgtec.com> <1461243895-30371-2-git-send-email-paul.burton@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461243895-30371-2-git-send-email-paul.burton@imgtec.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2016 at 02:04:45PM +0100, Paul Burton wrote: > The conditions for branching when emulating the BC1EQZ & BC1NEZ > instructions were backwards, leading to each of those instructions being > treated as the other. Fix this by reversing the conditions, and clear up > the code a little for readability & checkpatch. > > Fixes: c909ca718e8f ("MIPS: math-emu: Emulate missing BC1{EQ,NE}Z instructions") > Signed-off-by: Paul Burton > Reviewed-by: James Hogan Patch ok - but you may want to take Markos off the cc list. Or iff he's still interested, is there any new address for him to use instead? Ralf