From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbcEJSbh (ORCPT ); Tue, 10 May 2016 14:31:37 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36837 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbcEJSbf (ORCPT ); Tue, 10 May 2016 14:31:35 -0400 Date: Tue, 10 May 2016 11:31:48 -0700 From: Stephen Hemminger To: Harvey Hunt Cc: , Robert Jarzmik , Barry Song , Marcel Ziswiler , , Subject: Re: [PATCH net] drivers: net: Don't print unpopulated net_device name Message-ID: <20160510113148.4b4d0d6d@xeon-e3> In-Reply-To: <1462898601-5429-1-git-send-email-harvey.hunt@imgtec.com> References: <1462898601-5429-1-git-send-email-harvey.hunt@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 May 2016 17:43:21 +0100 Harvey Hunt wrote: > For ethernet devices, net_device.name will be eth%d before > register_netdev() is called. Don't print the net_device name until > the format string is replaced. > > Cc: Robert Jarzmik > Cc: Barry Song > Cc: Marcel Ziswiler > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Harvey Hunt > --- > I've tested this patch on a board that has a DM9000, but haven't > tested the other two network devices. > > drivers/net/ethernet/davicom/dm9000.c | 3 +-- > drivers/net/ethernet/micrel/ks8695net.c | 3 +-- > drivers/net/ethernet/netx-eth.c | 3 +-- > 3 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c > index 48d9194..89dcaa1 100644 > --- a/drivers/net/ethernet/davicom/dm9000.c > +++ b/drivers/net/ethernet/davicom/dm9000.c > @@ -1686,8 +1686,7 @@ dm9000_probe(struct platform_device *pdev) > } > > if (!is_valid_ether_addr(ndev->dev_addr)) { > - dev_warn(db->dev, "%s: Invalid ethernet MAC address. Please " > - "set using ifconfig\n", ndev->name); > + dev_warn(db->dev, "Invalid ethernet MAC address. Please set using ifconfig\n"); ifconfig is deprecated, therefore please don't tell users to use it.