From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
Cc: Rob Herring <robh@kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Pawel Moll <pawel.moll@arm.com>, Mark Brown <broonie@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Russell King <linux@arm.linux.org.uk>,
Josh Wu <rainyfeeling@outlook.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/2] mtd: atmel_nand: remove compatible "atmel,sama5d4-nfc"
Date: Tue, 10 May 2016 13:52:58 +0200 [thread overview]
Message-ID: <20160510115258.GS2890@piout.net> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A243641D6487F5A@penmbx01>
On 10/05/2016 at 04:50:37 +0000, Yang, Wenyou wrote :
>
>
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: 2016年5月10日 4:13
> > To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> > Cc: Brian Norris <computersforpeace@gmail.com>; David Woodhouse
> > <dwmw2@infradead.org>; Pawel Moll <pawel.moll@arm.com>; Mark Brown
> > <broonie@kernel.org>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar
> > Gala <galak@codeaurora.org>; linux-kernel@vger.kernel.org; linux-
> > mtd@lists.infradead.org; devicetree@vger.kernel.org; Ferre, Nicolas
> > <Nicolas.FERRE@atmel.com>; Alexandre Belloni <alexandre.belloni@free-
> > electrons.com>; Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>;
> > Russell King <linux@arm.linux.org.uk>; Josh Wu <rainyfeeling@outlook.com>;
> > linux-arm-kernel@lists.infradead.org
> > Subject: Re: [PATCH 0/2] mtd: atmel_nand: remove compatible "atmel,sama5d4-
> > nfc"
> >
> > On Mon, May 09, 2016 at 02:51:17PM +0800, Wenyou Yang wrote:
> > > It is a datasheet bug, for current SoCs, the RB_EDGE3(i.e. bit 27) of
> > > HSMC_SR register does not exist, the RB_EDGE0 (i.e. bit 24) is the
> > > ready/busy line edge status bit. So the compatible "atmel,sama5d4-nfc"
> > > is unneeded.
> >
> > The compatible is needed if the SOC still exists. You can list both for the sama5d4
> > if the block is the same.
>
> The NFC IP of SAMA5D4 is same as SAMA5D2's, SAMA5D4 hase this issue. This compatible can be removed.
>
Well, I agree with Rob, we don't remove an existing compatible. Simply
make it do the right thing (i.e. the same as sama5d3-nfc).
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-05-10 11:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 6:51 [PATCH 0/2] mtd: atmel_nand: remove compatible "atmel,sama5d4-nfc" Wenyou Yang
2016-05-09 6:51 ` [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE interrupts" Wenyou Yang
2016-05-10 8:55 ` Boris Brezillon
2016-05-10 8:59 ` Yang, Wenyou
2016-05-10 9:59 ` Romain Izard
2016-05-23 7:55 ` Boris Brezillon
2016-05-26 3:10 ` Brian Norris
2016-05-26 3:16 ` Brian Norris
2016-05-26 6:36 ` Boris Brezillon
2016-05-09 6:51 ` [PATCH 2/2] ARM: at91/dt: use "atmel,sama5d3-nfc" compatible for nfc Wenyou Yang
2016-05-09 16:34 ` [PATCH] ARM: dts: at91: sama5d2: " Nicolas Ferre
2016-05-09 17:17 ` Romain Izard
2016-05-09 20:13 ` [PATCH 0/2] mtd: atmel_nand: remove compatible "atmel,sama5d4-nfc" Rob Herring
2016-05-10 4:50 ` Yang, Wenyou
2016-05-10 11:52 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510115258.GS2890@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=Nicolas.FERRE@atmel.com \
--cc=Wenyou.Yang@atmel.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=rainyfeeling@outlook.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox