Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC

Vinod Koul
2016-05-10T15:50:32Z

On Wed, May 04, 2016 at 10:29:39PM +0300, Andy Shevchenko wrote:
> When check for capabilities recognize slave support by eother DMA_SLAVE or
^^^^^^^
typo

> DMA_CYCLIC bit set. If we don't do that the user can't get a normally worked
> DMA support for engines that doesn't have one of the mentioned bits set.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/dma/dmaengine.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index 5ff79a0..59eb4fa 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -482,8 +482,8 @@ int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
> device = chan->device;
>
> /* check if the channel supports slave transactions */
> - if ((!test_bit(DMA_SLAVE, device->cap_mask.bits)) ||
> - (!test_bit(DMA_CYCLIC, device->cap_mask.bits)))
> + if (!(test_bit(DMA_SLAVE, device->cap_mask.bits) ||
> + test_bit(DMA_CYCLIC, device->cap_mask.bits)))
> return -ENXIO;
>
> /*
> --
> 2.8.1
>

--
~Vinod