From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbcEJQGD (ORCPT ); Tue, 10 May 2016 12:06:03 -0400 Received: from mga03.intel.com ([134.134.136.65]:4805 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbcEJQGA (ORCPT ); Tue, 10 May 2016 12:06:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,604,1455004800"; d="scan'208";a="976748773" Date: Tue, 10 May 2016 21:41:52 +0530 From: Vinod Koul To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Peter Hurley , linux-serial@vger.kernel.org Subject: Re: [PATCH v1 2/2] dmaengine: rename cmd_pause to cmd_suspend Message-ID: <20160510161151.GI2274@localhost> References: <1462390180-82368-1-git-send-email-andriy.shevchenko@linux.intel.com> <1462390180-82368-3-git-send-email-andriy.shevchenko@linux.intel.com> <20160510155928.GH2274@localhost> <1462896023.17131.305.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462896023.17131.305.camel@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2016 at 07:00:23PM +0300, Andy Shevchenko wrote: > On Tue, 2016-05-10 at 21:29 +0530, Vinod Koul wrote: > > On Wed, May 04, 2016 at 10:29:40PM +0300, Andy Shevchenko wrote: > > > > > > Rename cmd_pause to cmd_suspend to be clear that latter capability > > > reflects > > > pause AND resume. > > How does cmd_suspend be any clearer to reflect that channel is paused > > and > > not. One can argue this might be related to power management suspend > > Okay, I'm open to suggestions. My main point that name should not > represent only pause or resume, rather both. I am actually okay with this name, but while getting the capablities, we should rather tell user if both are supported or not. Perhaps make it a bit mask? -- ~Vinod