Re: [PATCH v1 2/2] dmaengine: rename cmd_pause to cmd_suspend

Vinod Koul
2016-05-10T16:06:03Z

On Tue, May 10, 2016 at 07:00:23PM +0300, Andy Shevchenko wrote:
> On Tue, 2016-05-10 at 21:29 +0530, Vinod Koul wrote:
> > On Wed, May 04, 2016 at 10:29:40PM +0300, Andy Shevchenko wrote:
> > >
> > > Rename cmd_pause to cmd_suspend to be clear that latter capability
> > > reflects
> > > pause AND resume.
> > How does cmd_suspend be any clearer to reflect that channel is paused
> > and
> > not. One can argue this might be related to power management suspend
>
> Okay, I'm open to suggestions. My main point that name should not
> represent only pause or resume, rather both.

I am actually okay with this name, but while getting the capablities, we
should rather tell user if both are supported or not. Perhaps make it a
bit mask?

--
~Vinod