From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752694AbcEJQII (ORCPT ); Tue, 10 May 2016 12:08:08 -0400 Received: from mga14.intel.com ([192.55.52.115]:2146 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbcEJQIH (ORCPT ); Tue, 10 May 2016 12:08:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,604,1455004800"; d="scan'208";a="962922601" Date: Tue, 10 May 2016 21:43:57 +0530 From: Vinod Koul To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Peter Hurley , linux-serial@vger.kernel.org Subject: Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC Message-ID: <20160510161356.GJ2274@localhost> References: <1462390180-82368-1-git-send-email-andriy.shevchenko@linux.intel.com> <1462390180-82368-2-git-send-email-andriy.shevchenko@linux.intel.com> <20160510155637.GG2274@localhost> <1462896063.17131.306.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462896063.17131.306.camel@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2016 at 07:01:03PM +0300, Andy Shevchenko wrote: > On Tue, 2016-05-10 at 21:26 +0530, Vinod Koul wrote: > > On Wed, May 04, 2016 at 10:29:39PM +0300, Andy Shevchenko wrote: > > > > > > When check for capabilities recognize slave support by eother > > > DMA_SLAVE or > > ^^^^^^^ > > typo > > Indeed, thanks. > Do I need to resend this one? Yes please. Also instead of OR, AND will do the same, but your approach works too, so either way am fine.. And I do not get correlation with fix on patch 1. This should be independent change.. -- ~Vinod