From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbcEJQY2 (ORCPT ); Tue, 10 May 2016 12:24:28 -0400 Received: from mail.skyhub.de ([78.46.96.112]:55474 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbcEJQY1 (ORCPT ); Tue, 10 May 2016 12:24:27 -0400 Date: Tue, 10 May 2016 18:24:21 +0200 From: Borislav Petkov To: Paolo Bonzini Cc: Suravee Suthikulpanit , rkrcmar@redhat.com, joro@8bytes.org, gleb@kernel.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com Subject: Re: [PART1 V5 07/13] KVM: x86: Detect and Initialize AVIC support Message-ID: <20160510162421.GE16752@pd.tnic> References: <1462388992-25242-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1462388992-25242-8-git-send-email-Suravee.Suthikulpanit@amd.com> <20160510091447.GA16752@pd.tnic> <5731F379.9080309@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5731F379.9080309@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2016 at 04:43:05PM +0200, Paolo Bonzini wrote: > That was actually our suggestion. Despite the long names, the lines do > not come out too long because the masks are only used for writing > fields, not very much for reading them (e.g. in complex "if" conditions). Sure but how can one even read that? AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK AVIC's physical ID entry's host's physical ID's mask? That sucks in any language :-) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.