From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752084AbcEJTCZ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 May 2016 15:02:25 -0400
Received: from mx2.suse.de ([195.135.220.15]:47556 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751092AbcEJTCY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 May 2016 15:02:24 -0400
Date: Tue, 10 May 2016 21:02:18 +0200
From: Borislav Petkov <bp@suse.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86-ml <x86@kernel.org>, Denys Vlasenko <dvlasenk@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Brian Gerst <brgerst@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>, Andi Kleen <andi@firstfloor.org>,
        zengzhaoxiu@163.com, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>,
        Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH -v2] x86/hweight: Get rid of the special calling
 convention
Message-ID: <20160510190218.GH28520@pd.tnic>
References: <20160504184612.GC23257@pd.tnic>
 <CAMzpN2h5AroNfCYcmdRCTBQuqBc_r+i+yMqg2aDFQjwYKWZGOA@mail.gmail.com>
 <5998407c-3497-22c1-45dc-a86afcb73c94@zytor.com>
 <20160504194101.GE23257@pd.tnic>
 <f3405f2e-437c-a077-3a1c-90ff31e74787@zytor.com>
 <20160504202213.GF23257@pd.tnic>
 <572B446D.1030000@redhat.com>
 <20160505140446.GE534@pd.tnic>
 <20160510165318.GD28520@pd.tnic>
 <20160510172313.GA3192@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160510172313.GA3192@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 10, 2016 at 07:23:13PM +0200, Peter Zijlstra wrote:
> So what was wrong with using the normal thunk_*.S wrappers for the
> calls? That would allow you to use the alternative() stuff which does
> generate smaller code.

Yeah, so a full allyesconfig vmlinux gives ~22K .text size increase:

   text    data     bss     dec     hex filename
85391772        105899159       70717440        262008371       f9dee33 vmlinux 	before
85413991        105899223       70746112        262059326       f9eb53e vmlinux		after
--------
   22219

I guess I better try the thunk stuff, might make it smaller.

Also, in the next version I'll split out the static_cpu_has() move into
a separate patch, as you requested on IRC.

Thanks.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--