From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbcEJTLG (ORCPT ); Tue, 10 May 2016 15:11:06 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54890 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751466AbcEJTLE (ORCPT ); Tue, 10 May 2016 15:11:04 -0400 Date: Tue, 10 May 2016 21:10:45 +0200 From: Maxime Ripard To: Andre Przywara Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, olof@lixom.net, arnd@arndb.de Subject: Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip Message-ID: <20160510191045.GM3733@lukather> References: <1462833455-27720-1-git-send-email-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mkHYMT4O8DyWoHkb" Content-Disposition: inline In-Reply-To: <1462833455-27720-1-git-send-email-andre.przywara@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mkHYMT4O8DyWoHkb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 09, 2016 at 11:37:35PM +0100, Andre Przywara wrote: > From: Suzuki K Poulose >=20 > Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"), > added support for ARCH_SUNXI on arm64, but failed to select > GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c > and causes build failures like : >=20 > UPD include/generated/compile.h > CC init/version.o > LD init/built-in.o > drivers/built-in.o: In function `sunxi_sc_nmi_set_type': > drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_al= t_chip' > drivers/built-in.o: In function `irq_domain_add_linear': > include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_o= ps' > include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_o= ps' > drivers/built-in.o: In function `sunxi_sc_nmi_irq_init': > drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_do= main_generic_chips' > drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_doma= in_generic_chip' > drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_= clr_bit' > drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_= set_bit' > drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_s= et_bit' > drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_= clr_bit' >=20 > Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option= ") > Cc: Andre Przywara > Signed-off-by: Suzuki K Poulose > Signed-off-by: Andre Przywara Acked-by: Maxime Ripard Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --mkHYMT4O8DyWoHkb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXMjI1AAoJEBx+YmzsjxAg0X0P/2xIS2iItq51K+gLvKo4n5/j 4x7hx+6ObsERxQbjqcy8Fb7v5RSmHMAJpk/jzq5C1hqwrN7l9iq9fcEjaosTj464 0qhWdD+6eBBjwbnMvBOl6KKZlePE27IvF7FaCYeiZCFZfWojM9Erq9nR4cfv2k0X +2B45wTj2hw7ZUR/xxfx1Gr6EFPlyY6PH5tsIfgr6y2F1Vmi26ZQYM7d2IqqRpO1 T74+BvyMDkEiY1xwaQYbPfjeAS+x8otj3E/8jgmGBl/7/pYFJR1LgRnSzCPSaadm VSyy9EfvU/jE29zaCVmJETmisxHevVBb/FV73Tgwz0fSrfX7BUy0qt/7I0+y2zo5 PEWc+akt5H+6JUkjkRu6LqGKzfCn6+QgycYJEuzs/Byu3XqcmbXYLlY+mVnYX8u3 VRAy/wAPqSKg6SDiH+YxNXK3xXsiGepKsIoLocMEMfhlRDmoODjC07AbdFf5bbz9 z7hg69QRXGvGNwWd+VKD4mTgVmEkHZftHT6/Bc7DyI6nHaNi/FRUA2R6UMi0OPL2 VuV4IetGuuMJYoC6Gzmm8EfqXkZdUouYbJKgJ0Tc9EGKtmiLyV2JeEGEubyxTKsa ajFPDUN4a4rdYAhkG3OsTE27ssxDXMfG4ZzRH3DngBgWnYi9okzMT5Xpn1VI5ApD E8krlx4V3/GncJKoe5+O =Jsow -----END PGP SIGNATURE----- --mkHYMT4O8DyWoHkb--