From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752820AbcEJV3q (ORCPT ); Tue, 10 May 2016 17:29:46 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:35003 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbcEJV3o (ORCPT ); Tue, 10 May 2016 17:29:44 -0400 Date: Tue, 10 May 2016 23:29:42 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" Subject: Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: abstract VTU/STU data access Message-ID: <20160510212942.GA24788@lunn.ch> References: <1462909469-4827-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462909469-4827-1-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2016 at 03:44:28PM -0400, Vivien Didelot wrote: > Both VTU and STU operations use the same routine to access their > (common) data registers, with a different offset. > > Add VTU and STU specific read and write functions to the data registers > to abstract the required offset. > > Signed-off-by: Vivien Didelot Hi Vivien Improves the readability. Reviewed-by: Andrew Lunn Thanks Andrew