From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbcEKBTZ (ORCPT ); Tue, 10 May 2016 21:19:25 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:35528 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbcEKBTW (ORCPT ); Tue, 10 May 2016 21:19:22 -0400 Date: Tue, 10 May 2016 18:19:19 -0700 From: Brian Norris To: Shawn Lin Cc: Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dianders@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Message-ID: <20160511011919.GB77327@google.com> References: <1462924975-69072-1-git-send-email-briannorris@chromium.org> <1462924975-69072-2-git-send-email-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, May 11, 2016 at 08:59:24AM +0800, Shawn Lin wrote: > On 2016/5/11 8:02, Brian Norris wrote: > >The 'mmc-hs400-enhanced-strobe' property has been acked by Rob Herring, > >though it's still not merged. > > > > Hi Brain, > > I'm not sure whether it's acceptable to upstream new property which > isn't merged yet. My major concern is that as the patchset supporting > h400es will go through mmc tree, so if Ulf should want to shorten the > name (e.g mmc-hs400-es), you would respin this patch. Well, Heiko can determine when to accept this. I wanted to post it to get things moving, but I can drop that property for now if it's going to cause difficulty. > Thanks. > > >Signed-off-by: Brian Norris > >--- BTW, I meant to note here that I haven't personally tested this EVB. I have tested other boards. This patch mostly serves the purpose of an example user, for my purposes. Brian > > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > >diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >index 1a3eb1482050..ccfd2bcf02e1 100644 > >--- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >+++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > >@@ -89,6 +89,18 @@ > > status = "okay"; > > }; > > > >+&emmc_phy { > >+ status = "okay"; > >+}; > >+ > >+&sdhci { > >+ bus-width = <8>; > >+ mmc-hs400-1_8v; > >+ non-removable; > >+ mmc-hs400-enhanced-strobe; > >+ status = "okay"; > >+}; > >+ > > &uart2 { > > status = "okay"; > > }; > > > > > -- > Best Regards > Shawn Lin >