From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751795AbcEKCc3 (ORCPT ); Tue, 10 May 2016 22:32:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:57959 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbcEKCc2 (ORCPT ); Tue, 10 May 2016 22:32:28 -0400 Date: Tue, 10 May 2016 19:32:24 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation Message-ID: <20160511023224.GA15972@jaegeuk.gateway> References: <20160509115635.123946-1-yuchao0@huawei.com> <20160509230037.GA6889@jaegeuk.gateway> <20160510214125.GA9867@jaegeuk.gateway> <705bb492-b510-462e-fef3-d2f66dbb871f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <705bb492-b510-462e-fef3-d2f66dbb871f@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 10:22:05AM +0800, Chao Yu wrote: > On 2016/5/11 5:41, Jaegeuk Kim wrote: > > + > > + f2fs_wait_on_page_writeback(dn->node_page, NODE, true); > > + > > + for (; count > 0; dn->ofs_in_node++) { > > + block_t blkaddr = > > + datablock_addr(dn->node_page, dn->ofs_in_node); > > + if (blkaddr == NULL_ADDR) { > > + dn->data_blkaddr = NEW_ADDR; > > + __set_data_blkaddr(dn); > > + count--; > > + } > > + } > > Should let ofs_in_node increase to offset where blkaddr = NULL_ADDR in > ENOSPC case or increase to end_offset in normal case, right? hehe, I could get some errors on this patch. :) Finally, I've made a patch which passes xfstests and fsstress. Could you find the latest ones? http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev-test > > Thanks,