From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932179AbcEKMqo (ORCPT ); Wed, 11 May 2016 08:46:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46761 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbcEKMqm (ORCPT ); Wed, 11 May 2016 08:46:42 -0400 Date: Wed, 11 May 2016 14:46:39 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: x86: make hwapic_isr_update and hwapic_irr_update look the same Message-ID: <20160511124638.GA1859@potion> References: <1462898903-45526-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1462898903-45526-1-git-send-email-pbonzini@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 11 May 2016 12:46:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-05-10 18:48+0200, Paolo Bonzini: > Neither APICv nor AVIC actually need the first argument of > hwapic_isr_update, but the vCPU makes more sense than passing the > pointer to the whole virtual machine! In fact in the APICv case it's > just because the vCPU is used implicitly, through the loaded VMCS. > > The second argument instead is named differently, make it consistent. > > Cc: Radim Krčmář > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Radim Krčmář