From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: ebc-c384_wdt: Simplify ebc_c384_wdt_start timeout computation
Date: Wed, 11 May 2016 09:58:02 -0400 [thread overview]
Message-ID: <20160511135802.GA624@sophia> (raw)
In-Reply-To: <20160511134327.GA8192@roeck-us.net>
On Wed, May 11, 2016 at 06:43:27AM -0700, Guenter Roeck wrote:
>On Wed, May 11, 2016 at 09:05:51AM -0400, William Breathitt Gray wrote:
>> The ebc_c384_wdt_set_timeout function already rounds up timeout values
>> greater than 255 to a multiple of 60, so there is no need to round again
>> in the ebc_c384_wdt_start function; a timeout value greater than 255 in
>> ebc_c384_wdt_start will divide cleanly by 60.
>>
>... except if the timeout is set with the module parameter, which is now
>rounded down, which would be a problem since it would time out earlier than
>expected (a timeout of 299 seconds, set with the module parameter, would
>time out after 240 seconds). So you would have to do some calculations
>on the timeout value set with the module parameter to ensure that it is
>set to a correct value.
>
>Guenter
Oops, I overlooked that scenario. Please ignore this patch as your are
correct that a timeout set via module parameter would not necessarily be
a multiple of 60; timeout in the start callback should indeed be
rounded.
William Breathitt Gray
prev parent reply other threads:[~2016-05-11 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 13:05 [PATCH] watchdog: ebc-c384_wdt: Simplify ebc_c384_wdt_start timeout computation William Breathitt Gray
2016-05-11 13:43 ` Guenter Roeck
2016-05-11 13:58 ` William Breathitt Gray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511135802.GA624@sophia \
--to=vilhelm.gray@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox