From: Wolfram Sang <wsa@the-dreams.de>
To: Shardar Shariff Md <smohammed@nvidia.com>
Cc: ldewangan@nvidia.com, swarren@wwwdotorg.org,
thierry.reding@gmail.com, gnurou@gmail.com,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, jonathanh@nvidia.com
Subject: Re: [PATCH v7 2/4] i2c: tegra: calculate timeout for config load when needed
Date: Wed, 11 May 2016 16:42:31 +0200 [thread overview]
Message-ID: <20160511144230.GC1716@katana> (raw)
In-Reply-To: <1461591519-24602-2-git-send-email-smohammed@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
On Mon, Apr 25, 2016 at 07:08:37PM +0530, Shardar Shariff Md wrote:
> Instead of calculating timeout for the config load during init,
> calculate it after config load register is written by using
> readx_poll_timeout().
I don't understand this description. You replace the open coded timeout
routine with readx_poll_timeout. But I don't see any calculation moved?
> + err = readx_poll_timeout(readl, i2c_dev->base +
> + tegra_i2c_reg_addr(i2c_dev,
> + I2C_CONFIG_LOAD), val, val == 0,
> + 1000, I2C_CONFIG_LOAD_TIMEOUT);
readl_poll_timeout? And probably assign the address to a variable to
make the above code block more readable.
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-11 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:38 [PATCH v7 1/4] i2c: tegra: disable clock before returning error Shardar Shariff Md
2016-04-25 13:38 ` [PATCH v7 2/4] i2c: tegra: calculate timeout for config load when needed Shardar Shariff Md
2016-05-11 14:42 ` Wolfram Sang [this message]
2016-04-25 13:38 ` [PATCH v7 3/4] i2c: tegra: add separate function for config_load Shardar Shariff Md
2016-04-25 13:38 ` [PATCH v7 4/4] i2c: tegra: proper handling of error cases Shardar Shariff Md
2016-05-11 14:47 ` Wolfram Sang
2016-04-25 13:54 ` [PATCH v7 1/4] i2c: tegra: disable clock before returning error Wolfram Sang
2016-05-11 14:33 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511144230.GC1716@katana \
--to=wsa@the-dreams.de \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smohammed@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox