From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932652AbcEKQsi (ORCPT ); Wed, 11 May 2016 12:48:38 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33231 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932448AbcEKQsf (ORCPT ); Wed, 11 May 2016 12:48:35 -0400 Date: Wed, 11 May 2016 18:48:33 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] drm/fb-cma-helper: Hook up to DocBook and fix some docs Message-ID: <20160511164833.GR27098@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1462982962-10530-1-git-send-email-noralf@tronnes.org> <1462982962-10530-3-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1462982962-10530-3-git-send-email-noralf@tronnes.org> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 06:09:18PM +0200, Noralf Trønnes wrote: > Hook up fb_cma_helper to DocBook. Remove mention of > CONFIG_FB_DEFERRED_IO in the docs, which was forgotten in the latest > version of the deferred_io patch. > Use & when referencing drm_mode_config_funcs in docs. > > Signed-off-by: Noralf Trønnes First two patches applied to drm-misc, thanks. -Daniel > --- > Documentation/DocBook/gpu.tmpl | 5 +++++ > drivers/gpu/drm/drm_fb_cma_helper.c | 8 +++----- > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/Documentation/DocBook/gpu.tmpl b/Documentation/DocBook/gpu.tmpl > index 9dd48f7..4a0c599 100644 > --- a/Documentation/DocBook/gpu.tmpl > +++ b/Documentation/DocBook/gpu.tmpl > @@ -1617,6 +1617,11 @@ void intel_crt_init(struct drm_device *dev) > !Iinclude/drm/drm_fb_helper.h > > > + Framebuffer CMA Helper Functions Reference > +!Pdrivers/gpu/drm/drm_fb_cma_helper.c framebuffer cma helper functions > +!Edrivers/gpu/drm/drm_fb_cma_helper.c > + > + > Display Port Helper Functions Reference > !Pdrivers/gpu/drm/drm_dp_helper.c dp helpers > !Iinclude/drm/drm_dp_helper.h > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c > index 086f600..3165ac0 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -43,14 +43,12 @@ struct drm_fbdev_cma { > * Provides helper functions for creating a cma (contiguous memory allocator) > * backed framebuffer. > * > - * drm_fb_cma_create() is used in the > - * (struct drm_mode_config_funcs *)->fb_create callback function to create the > - * cma backed framebuffer. > + * drm_fb_cma_create() is used in the &drm_mode_config_funcs ->fb_create > + * callback function to create a cma backed framebuffer. > * > * An fbdev framebuffer backed by cma is also available by calling > * drm_fbdev_cma_init(). drm_fbdev_cma_fini() tears it down. > - * If CONFIG_FB_DEFERRED_IO is enabled and the callback > - * (struct drm_framebuffer_funcs)->dirty is set, fb_deferred_io > + * If the &drm_framebuffer_funcs ->dirty callback is set, fb_deferred_io > * will be set up automatically. dirty() is called by > * drm_fb_helper_deferred_io() in process context (struct delayed_work). > * > -- > 2.8.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch