From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbcEKQzd (ORCPT ); Wed, 11 May 2016 12:55:33 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34543 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbcEKQzb (ORCPT ); Wed, 11 May 2016 12:55:31 -0400 Date: Wed, 11 May 2016 18:55:29 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/6] drm/atomic: Add drm_atomic_helper_best_encoder() Message-ID: <20160511165529.GT27098@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1462982962-10530-1-git-send-email-noralf@tronnes.org> <1462982962-10530-6-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1462982962-10530-6-git-send-email-noralf@tronnes.org> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 06:09:21PM +0200, Noralf Trønnes wrote: > Add (struct drm_connector_helper_funcs *)->best_encoder callback helper > for connectors that support exactly 1 encoder, statically determined at > driver init time. > > Signed-off-by: Noralf Trønnes Applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/drm_atomic_helper.c | 17 +++++++++++++++++ > include/drm/drm_atomic_helper.h | 2 ++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index 46a3201..43a0b3d 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -2483,6 +2483,23 @@ backoff: > EXPORT_SYMBOL(drm_atomic_helper_connector_dpms); > > /** > + * drm_atomic_helper_best_encoder - Helper for &drm_connector_helper_funcs > + * ->best_encoder callback > + * @connector: Connector control structure > + * > + * This is a &drm_connector_helper_funcs ->best_encoder callback helper for > + * connectors that support exactly 1 encoder, statically determined at driver > + * init time. > + */ > +struct drm_encoder * > +drm_atomic_helper_best_encoder(struct drm_connector *connector) > +{ > + WARN_ON(connector->encoder_ids[1]); > + return drm_encoder_find(connector->dev, connector->encoder_ids[0]); > +} > +EXPORT_SYMBOL(drm_atomic_helper_best_encoder); > + > +/** > * DOC: atomic state reset and initialization > * > * Both the drm core and the atomic helpers assume that there is always the full > diff --git a/include/drm/drm_atomic_helper.h b/include/drm/drm_atomic_helper.h > index 0364287..ccca709 100644 > --- a/include/drm/drm_atomic_helper.h > +++ b/include/drm/drm_atomic_helper.h > @@ -110,6 +110,8 @@ int drm_atomic_helper_page_flip(struct drm_crtc *crtc, > uint32_t flags); > int drm_atomic_helper_connector_dpms(struct drm_connector *connector, > int mode); > +struct drm_encoder * > +drm_atomic_helper_best_encoder(struct drm_connector *connector); > > /* default implementations for state handling */ > void drm_atomic_helper_crtc_reset(struct drm_crtc *crtc); > -- > 2.8.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch