From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752491AbcEKTtM (ORCPT ); Wed, 11 May 2016 15:49:12 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35146 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752187AbcEKTtJ (ORCPT ); Wed, 11 May 2016 15:49:09 -0400 Date: Wed, 11 May 2016 12:49:05 -0700 From: Bjorn Andersson To: Andy Gross Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Boyd , jilai wang Subject: Re: [Patch v4 1/8] dt/bindings: firmware: Add Qualcomm SCM binding Message-ID: <20160511194905.GU1256@tuxbot> References: <1462976158-26016-1-git-send-email-andy.gross@linaro.org> <1462976158-26016-2-git-send-email-andy.gross@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462976158-26016-2-git-send-email-andy.gross@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 11 May 07:15 PDT 2016, Andy Gross wrote: > This patch adds the device tree support for the Qualcomm SCM firmware. > > Signed-off-by: Andy Gross > --- > .../devicetree/bindings/firmware/qcom,scm.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.txt > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt > new file mode 100644 > index 0000000..0c5f1ff > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt > @@ -0,0 +1,28 @@ > +QCOM Secure Channel Manager (SCM) > + > +Qualcomm processors include an interface to communicate to the secure firmware. > +This interface allows for clients to request different types of actions. These > +can include CPU power up/down, HDCP requests, loading of firmware, and other > +assorted actions. > + > +Required properties: > +- compatible: must contain one of the following: > + * "qcom,scm-apq8064" for APQ8064 platforms > + * "qcom,scm-msm8660" for MSM8660 platforms > + * "qcom,scm-msm8690" for MSM8690 platforms > + * "qcom,scm" for later processors (MSM8916, APQ8084, MSM8974, etc) > +- clocks: One to three clocks may be required based on compatible. > + * Only core clock required for "qcom,scm-apq8084", "qcom,scm-msm8660", and "qcom,scm-msm8960" > + * Core, iface, and bus clocks required for "qcom,scm" > +- clock-names: Must contain "core" for the core clock, "iface" for the interface > + clock and "bus" for the bus clock per the requirements of the compatible. I like this split of generic binding and the special cases, gives the wanted clarity for the outliers without the added churn in the common case. Acked-by: Bjorn Andersson Regards, Bjorn