From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752491AbcEKUvY (ORCPT ); Wed, 11 May 2016 16:51:24 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46430 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbcEKUvW (ORCPT ); Wed, 11 May 2016 16:51:22 -0400 Date: Wed, 11 May 2016 21:50:52 +0100 From: Mark Brown To: Peter Rosin Cc: linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org Message-ID: <20160511205052.GU6261@sirena.org.uk> References: <1462892797-1147-1-git-send-email-peda@axentia.se> <20160511150937.GK6261@sirena.org.uk> <65bdbaea-fe4e-bbd5-335d-a8d594936cbe@axentia.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JcGvecxLhm+LytDG" Content-Disposition: inline In-Reply-To: <65bdbaea-fe4e-bbd5-335d-a8d594936cbe@axentia.se> X-Cookie: When in doubt, follow your heart. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: MAX9860: new driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JcGvecxLhm+LytDG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 11, 2016 at 10:12:56PM +0200, Peter Rosin wrote: > On 2016-05-11 17:09, Mark Brown wrote: > > On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote: > >> This driver does not support sidetone since the DVST register field is > >> backwards with the mute near the maximum level instead of the minimum. > > Why would that be an issue? We support volume controls in either > > direction. > I asked about this last week (or so), maybe that question explains the > situation? > http://www.spinics.net/lists/alsa-devel/msg49675.html If you don't CC maintainers the chances are your mails just won't get seen... You should change DAPM so that it understands what your control is doing, possibly by using custom accessors though it seems like something in the vein of the invert flag ought to do the trick. You don't want to actually use the invert flag since increasing values do mean increasing volume but something along those lines. Possibly doing it by parsing the TLV for a mute value at probe time might make sense? --JcGvecxLhm+LytDG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXM5srAAoJECTWi3JdVIfQSlwH+QHYeaXljwmyRmDYmlAWP9Eb QXi7Gk+LYSlR0vh705aOGdi9oK3cWGEK7MA9yzex9hSB6gRMQsXLdSgVoHU92WWJ E9WZSeTXuszSMEvqIOCGp6QaSA8HFMeH9ZzwOgOS9CP6pR+KBvJ/BZv4maUbcCw5 l0dYUdwSaR+Hrm2iwcpTpllIlRvXtjryYJSIYATGMChs73o67GUxnv5YR9NH9x8I 79HnhjOGTV77SHwJIRrdOgIxIk5I6hbsjCClr8y/vm/AHsoj/ROImVaL14Qn+OCD +H6nGgTdzDQQUl0LcHnnU4wVFx3tsJhpopjtLkXlZN6HdS1IiKyLQ1UHRNVAWCU= =oSLw -----END PGP SIGNATURE----- --JcGvecxLhm+LytDG--