From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbcEKWch (ORCPT ); Wed, 11 May 2016 18:32:37 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34012 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbcEKWcg (ORCPT ); Wed, 11 May 2016 18:32:36 -0400 Date: Wed, 11 May 2016 15:32:33 -0700 From: Brian Norris To: Heiko Stuebner Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dianders@chromium.org, Shawn Lin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Message-ID: <20160511223233.GB65449@google.com> References: <1462924975-69072-1-git-send-email-briannorris@chromium.org> <1462924975-69072-2-git-send-email-briannorris@chromium.org> <4355979.JCGxOmTVBW@phil> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4355979.JCGxOmTVBW@phil> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote: > Hi Brian, > > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris: > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob Herring, > > though it's still not merged. > > The commit message should describe the actual change not the volatile > environment surrounding it :-) . > > When I apply this patch the property-binding will have made it into a > maintainer-tree so is not valid anymore then. That is more material for the > "comment-section" below the "---" Of course. I think I just felt guilty without a commit message :) > > Signed-off-by: Brian Norris > > --- > > arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > > b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index > > 1a3eb1482050..ccfd2bcf02e1 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts > > @@ -89,6 +89,18 @@ > > status = "okay"; > > }; > > > > +&emmc_phy { > > + status = "okay"; > > +}; > > + > > +&sdhci { > > + bus-width = <8>; > > + mmc-hs400-1_8v; > > + non-removable; > > + mmc-hs400-enhanced-strobe; > > alphabetic ordering of properties please Will fix. Thanks, Brian > > + status = "okay"; > > +}; > > + > > &uart2 { > > status = "okay"; > > }; >