From: Andi Kleen <ak@linux.intel.com>
To: Kees Cook <keescook@chromium.org>
Cc: Hector Marco-Gisbert <hecmargi@upv.es>,
Andy Lutomirski <luto@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Brian Gerst <brgerst@gmail.com>, Borislav Petkov <bp@suse.de>,
Huaitong Han <huaitong.han@intel.com>,
Ismael Ripoll Ripoll <iripoll@upv.es>
Subject: Re: [PATCH] x86_64: Disabling read-implies-exec when the stack is executable
Date: Wed, 11 May 2016 15:40:58 -0700 [thread overview]
Message-ID: <20160511224058.GL11177@tassilo.jf.intel.com> (raw)
In-Reply-To: <CAGXu5jJt1YPvR903ivFCmnwu1b++mEZhbfm8k8kLwPNwCqpnbQ@mail.gmail.com>
> However, I would tend to agree: RIE should only be needed on 32-bit
> since 64-bit started its life knowing about no-exec permissions.
NX was not in the original AMD K8 chips. Was only added some time later.
> set_personality_64bit()'s (which is confusingly just an initializer
> and not called during the personality() syscall) comment about this
> makes no sense to me:
>
> /* TBD: overwrites user setup. Should have two bits.
> But 64bit processes have always behaved this way,
> so it's not too bad. The main problem is just that
> 32bit childs are affected again. */
> current->personality &= ~READ_IMPLIES_EXEC;
What does not make sense?
-Andi
next prev parent reply other threads:[~2016-05-11 22:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 10:45 [PATCH] x86_64: Disabling read-implies-exec when the stack is executable Hector Marco-Gisbert
2016-05-11 20:49 ` Kees Cook
2016-05-11 22:40 ` Andi Kleen [this message]
2016-05-12 2:11 ` Kees Cook
2016-05-16 10:58 ` Ingo Molnar
2019-04-18 7:45 ` Kees Cook
2019-04-18 8:17 ` Thomas Gleixner
2019-04-18 14:11 ` Kees Cook
2019-04-18 14:14 ` Andy Lutomirski
2019-04-18 14:29 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511224058.GL11177@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=bp@suse.de \
--cc=brgerst@gmail.com \
--cc=hecmargi@upv.es \
--cc=hpa@zytor.com \
--cc=huaitong.han@intel.com \
--cc=iripoll@upv.es \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox