From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932446AbcELNTb (ORCPT ); Thu, 12 May 2016 09:19:31 -0400 Received: from mail-bn1bon0086.outbound.protection.outlook.com ([157.56.111.86]:51328 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751395AbcELNT1 (ORCPT ); Thu, 12 May 2016 09:19:27 -0400 Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Thu, 12 May 2016 15:59:09 +0300 From: Yury Norov To: "Zhangjian (Bamvor)" CC: Arnd Bergmann , , , Andrew Pinski , , , Hanjun Guo , , , , "jijun (D)" , , , , , , , , , Andrew Pinski , , Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Message-ID: <20160512125909.GA29077@yury-N73SV> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <573305A8.50406@huawei.com> <5733149C.4030903@huawei.com> <5250356.myv9GIZ34h@wuerfel> <5733FC71.8070101@huawei.com> <20160512082427.GA1587@yury-N73SV> <57347C9E.7010708@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <57347C9E.7010708@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM3PR01CA062.eurprd01.prod.exchangelabs.com (10.141.191.52) To BN4PR07MB2226.namprd07.prod.outlook.com (10.164.63.144) X-MS-Office365-Filtering-Correlation-Id: 187d6f8f-81d3-4d80-948b-08d37a65d8bc X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;2:iuMsEsw2eyaFRgyKanIEOS/Vtdz4JK2dUvRW33L681l7hn7k3d9IK9fzrOGuah+F6ME1BDkOhb7x3DvedpRfP+yXKKz7ro4D3lcm02JgEyuu71UO9OEmDrqhEfdvjWK9h6jaQOjVztuXVPlKREVq5FbD1DLWIjWPe0Zf0mF6fcLqSSObuRkMDdn7C7Dj6jRO;3:iH5Ig1xgWSkpticTwJV2SvwYYU+VZpBKwLkp7CpRlaFyyhpk1jDkEFkgw3PXmcVivEPAZPY1woPJki0Tzm7pfhy0rhRiCJ/ZHX2OVxYBfyr5soB3MO4YC8bnh4i0UTdZ;25:rbVSOcWeii1Q5QWZL7rgvjzm0LEtIyPNuBzqlq3dNAKYT6FN4JVPwZqVurrT0SKiqIHLivKkrHPcyOuYX/FVWfpak+66KCYSW6jhfSpO0A3JDTgAuERrEo7ZhIqtomMbJlXVC5iAU28lZC6IlA4mhT3JF2tbDjzJEjmyPN5ZOUPYDH93/fta/LCdzU+u2QlWx0RkKPErTM69jfqIY2PDApV8NrzabfZSGos0BQsvfcXZY1SNn51QkK//gbgDeoqR1K/eztdA5vEG/hOxHmIovmGFnkS/EP7alJt37lQWmr9CtcNSTmxGPd5DWfCKq2hgLZ/xbiUPQpIF+oCIquTQ5pjnAyghbP64yuEOCESLnFI9Uu9RpnMQzDhcekkK2gVgpjyxcw33sx2qn1VghX5OdX042quQPMpSOqc21ZCY2B0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2226; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;20:Od24rEhwYAsbWWxA7aO6ocaMF2Tyhv2qIG/hz7pOdM0kHL8KOrgXH7uj8FuMoO4MCH8AHcKiSoG2IbpB2BLr2FE5ayTsUSWTpEK80F+0qf++CxNSckt45/zuVU8Q1iKwpcN7lqy9IcXcJvTyruxXIuNu4nyVfpfl9WZGKUyRUT+VB0J0Ix3C6cIu60fHQn2plMq8qkayaCX181/g3ZO0yyjWFVjp7jtLg0wwrB4rI9nyGou6Z6YdqBYhDS2j5bYzl6tkK2RUMzkhLCNWPYK+YtfL7Dh82cTYCnKMtMmHThZHGse/Nf3XXLUG4YGaTrPoTWwqapbAiQ5z/AwDMTm1qLoDe+CiRKc+aMxCY64CR6eYmHA2ppX6oodJaSzSUSZMvJtBYe/UQ+QU4Z24oqjsd8+Ys2lNVGfo03CYQBwxRfMLtXDEXx7xnL6JJ4K6OGW4ygNzHS1IvcTcwTbcpQjy6oXiX331P2YMTb6Uw3OWrdZyldHzWGk6PxwNkX7sSy25VVTPJ3GvtbT+/8bOA9pnIXAS378ZAhjyGVKwIP2SO2EtAHBEw8rOUsip2ygbLt3Val09fNo86Q5Sfw7VriaNCUxpLlAU4c/yd/YiQKo3gKo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BN4PR07MB2226;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2226; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;4:v9SG1qeL/wysN8xdsW3C4voWp7FWsZ55kmb7ognaH9Gk43IRvyv1vbs19BZTQHgA0GMi+aDrPZ4nUOXSvbkCWG2rYlVbqWMKaVbrEG/YKc48mc16qmzwjPlHiJHyO74Q8kHxuDtrhfnnX9/gNdiigi+bhwBbsPsQf+6/KzPIQvjiepXEd00UL8tmvXflf1b/JcGxdSh97sbLG/ZUK+i4Eua5ViTIM+JogE63WQlUyYnRcjlgNZydrqUa/Br8AYH8rrzoYYzvAMVAY/2v1TDZEwZiIzAAh7L5BI5leXSXCyHb5IrfbvsgCKOZcn5HJcCaPoyWn5uGRIJDfV52+MNxu1dS/7fHJfvDdZsDC4zFiYQ2NKDrj9G5F5pTWkJJnTkE X-Forefront-PRVS: 0940A19703 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(24454002)(76506005)(47776003)(33656002)(110136002)(23726003)(83506001)(97756001)(6116002)(3846002)(42186005)(1076002)(50466002)(93886004)(586003)(5008740100001)(9686002)(66066001)(2950100001)(4001350100001)(92566002)(81166006)(189998001)(50986999)(77096005)(33716001)(5004730100002)(46406003)(54356999)(76176999)(2906002)(21314002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2226;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;23:cN0kQoD52iNmYz0yonXgmAnvRkKiVqyg+687/co+aKZTi8yWm0yn0phj9P/vYvc0aeddIslaRPWhZXARSzm3aXj5Uwwm3YB9btDLTVeTjcpb0XtisLrnwFkEEH0IhzAxoSyLVZ5e6LYVVSpJGEi8S6iXR10uCPxR0qO6M3pkyuu9s89TyxKfEb6zP4Nd96ee/uqmALMJJ0eDDBY9rNog/oaAC6rSOBZtk6R/R6je0z3auAEXe6koyZ78jOqz90kqiUAsj7R284zaNCBx8RSeGTNkW93Gf83AkrL68/aEgLzVL1h5JFzC5MKUQY2hdS4bl1aQ5FCCLk3JluG07DkvEmB/lsJ36oIj9qQ4rnHfBK0z/JFr9pBRuOmMgmw9uMLZytkWIdZ5p8GE/Ws37oKeNY6yagDgih74D30YSvaKOihvEE2hgYXrbw0wSxUBsdqwGPvTq/XvicmTjGX86n7IeUs24vrSKG9ET1tYvac4idZFPXQIvAXp5YAWHjnHWyvs51C6Rl4MTAAA4jl5QqBTPJbydrKjZPy69DKXu7sV+h0YqVNhVTn00v6R+J9rPNQivAvUpzJcw9bgtz+JgZ37XIzQ6RzykbmaqQ2mUSuegbkolJ7qRChLoPB/vB3MJehL0j/A1sQxdkRT1a5zXMc1IB3D0WB+6BStqBf4ZlhCBgnGHEnzAwCmeoi5QBLc1APdUcY+nqk6JrGIRXsgfWLM8PETGMv4dLK6a8/5o+piT0gVFCDP7/6ycsaGMiBGyGS1l7I53PAd/3pHMcXWF1y76SS7UYJRGXHB5uF9zbP0qo8Io4CAFurO8omRMa94NFmf4B1KQ7M/RJd5PviXev7AowCsgOSeNKWkY27ZTQNFvTUdfY6VRuzaj/YF62AETZqlg9+slZ/O6bgWXXvyA7HlunME3yjy+kaklq2tcK/tVJG21q0FbUkt23o9w5CHpZdQ X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;5:n7d9OwPtQGVBhgBgxIQmZMSRkFiT4t+fZ3D03aW4eGboBrK0HBrMYMrODJ1SZ+6UY/GEH3n1BtIea7wWsSgiq1tE3saauBLebSJxUzRuVwdNzSBMwPe3bz3lFQX1P4fiuGnVMZqg/z7fHVku1cldBw==;24:1CBmdM99873OtBxKirba91fJGVEZz4Ac5+EgRq9Yat0PXcjE/+ksrVOiyJ0Pwvjk7zoFqGHReR6If3ovwuiRCw0H4iKLP0tb3MboUnjmhgs=;7:w0uotEkKqgHyw4olee8HSwIzlf+y3CVQlp62ZRnBfEL/hFBIQ1HrkFXnvvbrjDkGqcVRYUt71mq3g4t9c53IHoSpcRH/U/4LSo2N4QlLmcQTwdlljSzNSaAI/es+aDKfep9MeiE6XiXiyOrH2F2pB8vtpJmMPMNGGjLmfpTJs6kavIahMVp44MbGaXvcn+yl SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2016 13:03:43.2926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2226 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 08:52:46PM +0800, Zhangjian (Bamvor) wrote: > Hi, > > On 2016/5/12 16:24, Yury Norov wrote: > >On Thu, May 12, 2016 at 11:45:53AM +0800, Zhangjian (Bamvor) wrote: > > > >[...] > > > >>>Hmm, that is indeed tricky. I think COMPAT_SYSCALL_WRAP4 rightfully > >>>refuses the loff_t argument here, as the common case is that this is > >>>not possible. > >>It works if I apply the following patch, I defined the wrong `__TYPE_IS_xxx` > >>yesterday. Should we merge this into ILP32 series or send the compat.h > >>and syscalls.h individually? The current series of ILP32 is a little bit > >>long and hard to review. > >>diff --git a/include/linux/compat.h b/include/linux/compat.h > >>index ba6ebe0..22a9565 100644 > >>--- a/include/linux/compat.h > >>+++ b/include/linux/compat.h > >>@@ -747,7 +747,8 @@ asmlinkage long compat_sys_fanotify_mark(int, unsigned int, __u32, __u32, > >> #ifndef __SC_COMPAT_CAST > >> #define __SC_COMPAT_CAST(t, a) ({ \ > >> BUILD_BUG_ON((sizeof(t) > 4) && !__TYPE_IS_L(t) && \ > >>- !__TYPE_IS_UL(t) && !__TYPE_IS_PTR(t)); \ > >>+ !__TYPE_IS_UL(t) && !__TYPE_IS_PTR(t) && \ > >>+ !__TYPE_IS_LOFFT(t)); \ > > > >I think it's wrong, as loff_t is 64-bit in 32-bit userspace, and this > >will clear meaningful data in top halve. > Yes. It is my fault. The original thoughts is clear the up 32bit for size_t. > How should we skip the loff_t? > > Regards > > Bamvor I already suggested: For cases like this I think we should write wrappers by hands. In unistd.h we can use __SC_WRAP, so they will work like wrappers generated by COMPAT_SYSCALL_WRAPx() Do you see any downsides?