From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932440AbcELPcO (ORCPT ); Thu, 12 May 2016 11:32:14 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35158 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752706AbcELPcL (ORCPT ); Thu, 12 May 2016 11:32:11 -0400 Date: Thu, 12 May 2016 17:32:08 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, linux-kernel@vger.kernel.org, jsarha@ti.com Subject: Re: [PATCH v3 2/2] drm: Add helper for simple display pipeline Message-ID: <20160512153208.GY27098@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jsarha@ti.com References: <1463057606-1916-1-git-send-email-noralf@tronnes.org> <1463057606-1916-3-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1463057606-1916-3-git-send-email-noralf@tronnes.org> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 02:53:26PM +0200, Noralf Trønnes wrote: > +/** > + * struct drm_simple_display_pipe - simple display pipeline > + * @crtc: CRTC control structure > + * @plane: Plane control structure > + * @encoder: Encoder control structure > + * @connector: Connector control structure > + * @funcs: Pipeline control functions (optional) > + * > + * Simple display pipeline with plane, crtc and encoder collapsed into one > + * entity. It should be initialized by calling drm_simple_display_pipe_init(). > + */ > +struct drm_simple_display_pipe { > + struct drm_crtc crtc; > + struct drm_plane plane; > + struct drm_encoder encoder; > + struct drm_connector *connector; > + > + struct drm_simple_display_pipe_funcs *funcs; > +}; Same thing as in the previous patch: Function table pointers should be const. I totally forgot about this. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch