From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbcELQXd (ORCPT ); Thu, 12 May 2016 12:23:33 -0400 Received: from mail-qg0-f67.google.com ([209.85.192.67]:33170 "EHLO mail-qg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbcELQXb (ORCPT ); Thu, 12 May 2016 12:23:31 -0400 Date: Thu, 12 May 2016 12:04:57 -0400 From: Tejun Heo To: Arnd Bergmann Cc: Mans Rullgard , Andy Shevchenko , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ata: dwc: add DMADEVICES dependency Message-ID: <20160512160457.GV4775@htj.duckdns.org> References: <1462974151-1467200-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462974151-1467200-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 03:42:08PM +0200, Arnd Bergmann wrote: > The dwc_460ex SATA driver has become available on non-powerpc architectures > and may cause randconfig build errors when CONFIG_DMADEVICES is not set > and SATA_DWC_OLD_DMA is enabled: > > warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES) > ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined! > ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined! > > This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we > cannot run into broken configurations. While it would also be > possible to build the driver with both CONFIG_DMADEVICES > and SATA_DWC_OLD_DMA disabled, that case is not useful because > there is no fallback to PIO mode when the DMA engine is not > usable. > > Signed-off-by: Arnd Bergmann > Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel") Applied to libata/for-4.7-dw. Thanks. -- tejun