From: Yuyang Du <yuyang.du@intel.com>
To: morten.rasmussen@arm.com, linux-kernel@vger.kernel.org,
efault@gmx.de, wanpeng.li@hotmail.com, peterz@infradead.org,
hpa@zytor.com, torvalds@linux-foundation.org, tglx@linutronix.de,
mingo@kernel.org
Cc: vincent.guittot@linaro.org, bsegall@google.com
Subject: Re: [tip:sched/core] sched/fair: Clean up scale confusion
Date: Fri, 13 May 2016 03:42:24 +0800 [thread overview]
Message-ID: <20160512194224.GA22541@intel.com> (raw)
In-Reply-To: <tip-1be0eb2a97d756fb7dd8c9baf372d81fa9699c09@git.kernel.org>
On Thu, May 12, 2016 at 03:31:27AM -0700, tip-bot for Peter Zijlstra wrote:
> Commit-ID: 1be0eb2a97d756fb7dd8c9baf372d81fa9699c09
> Gitweb: http://git.kernel.org/tip/1be0eb2a97d756fb7dd8c9baf372d81fa9699c09
> Author: Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Fri, 6 May 2016 12:21:23 +0200
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 12 May 2016 09:55:33 +0200
>
> sched/fair: Clean up scale confusion
>
> Wanpeng noted that the scale_load_down() in calculate_imbalance() was
> weird. I agree, it should be SCHED_CAPACITY_SCALE, since we're going
> to compare against busiest->group_capacity, which is in [capacity]
> units.
>
> Reported-by: Wanpeng Li <wanpeng.li@hotmail.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Morten Rasmussen <morten.rasmussen@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Yuyang Du <yuyang.du@intel.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
It is good that this issue is addressed and patch merged, however, for the
record, Vincent has already had a solution for this, and we had a patch,
including other cleanups (the latest version is: https://lkml.org/lkml/2016/5/3/925).
And I think Ben first pointed this out (and we then attempted to address it)
as far as I can tell.
next parent reply other threads:[~2016-05-13 3:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-1be0eb2a97d756fb7dd8c9baf372d81fa9699c09@git.kernel.org>
2016-05-12 19:42 ` Yuyang Du [this message]
2016-05-13 7:23 ` [tip:sched/core] sched/fair: Clean up scale confusion Vincent Guittot
2016-05-20 10:12 ` Morten Rasmussen
2016-05-23 10:27 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512194224.GA22541@intel.com \
--to=yuyang.du@intel.com \
--cc=bsegall@google.com \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox