From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751281AbcELUTT (ORCPT ); Thu, 12 May 2016 16:19:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56285 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbcELUTS (ORCPT ); Thu, 12 May 2016 16:19:18 -0400 Date: Thu, 12 May 2016 16:19:10 -0400 From: Peter Jones To: Andy Lutomirski Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Fleming Subject: Re: [PATCH] efifb: Don't show the mapping VA Message-ID: <20160512201910.GD1973@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 12 May 2016 20:19:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 04:57:47PM -0700, Andy Lutomirski wrote: > The framebuffer mapping virtual address leaks information about the > kernel memory layout. Stop logging it. > > Cc: Peter Jones > Cc: Jean-Christophe Plagniol-Villard > Cc: Tomi Valkeinen > Cc: linux-fbdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Andy Lutomirski In practice it also hasn't ever helped any actual debugging. Signed-off-by: Peter Jones > --- > drivers/video/fbdev/efifb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > index 95d293b7445a..3dcaf4e82885 100644 > --- a/drivers/video/fbdev/efifb.c > +++ b/drivers/video/fbdev/efifb.c > @@ -247,10 +247,8 @@ static int efifb_probe(struct platform_device *dev) > goto err_release_fb; > } > > - printk(KERN_INFO "efifb: framebuffer at 0x%lx, mapped to 0x%p, " > - "using %dk, total %dk\n", > - efifb_fix.smem_start, info->screen_base, > - size_remap/1024, size_total/1024); > + printk(KERN_INFO "efifb: framebuffer at 0x%lx, using %dk, total %dk\n", > + efifb_fix.smem_start, size_remap/1024, size_total/1024); > printk(KERN_INFO "efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n", > efifb_defined.xres, efifb_defined.yres, > efifb_defined.bits_per_pixel, efifb_fix.line_length, > -- > 2.5.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Peter